This repository was archived by the owner on Sep 21, 2024. It is now read-only.
fix hardcoded port number in Helloworld sample#111
Open
zllai wants to merge 576 commits intomicrosoft:masterfrom
Open
fix hardcoded port number in Helloworld sample#111zllai wants to merge 576 commits intomicrosoft:masterfrom
zllai wants to merge 576 commits intomicrosoft:masterfrom
Conversation
Rare concurrecy bug fixes
…oft#32) * Change variable names to match Ambrosia terminology change * Add quick start instructions to UWPExample README * Update UWPExample codegen script and improve error messages
Refactoring CodeGen tool
…S ... same for the Debug version too
…CRA Version=2019.8.8.2
…into Updating_CRA
…d MacOS (no docker) but Linux (no docker) still fails to build the right files
|
|
zllai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered
permission deniedwhen running Helloworld sample on Linux, because the client uses ports lower than 1024, which requires root in Linux. However, after I modified the port numbers inrun_helloworld_both.sh, the problem still exists.It turns out the port numbers are hard-coded in
Client*/Program.cs. So I made this pull request for following changes:Modify the default port numbers as following so that no root is required to run the sample on Linux:
Allow clients to receive port numbers in
args.In
run_helloworld_client.sh, pass port numbers toclient.dll.Make documents consistent with above changes.