fix: update VM size to Standard_D2s_v5 and update documentation for the same#138
Open
Harsh-Microsoft wants to merge 1 commit intodevfrom
Open
fix: update VM size to Standard_D2s_v5 and update documentation for the same#138Harsh-Microsoft wants to merge 1 commit intodevfrom
Harsh-Microsoft wants to merge 1 commit intodevfrom
Conversation
…ployment templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the default jumpbox VM size to
Standard_D2s_v5across the deployment templates and documentation. It also improves troubleshooting guidance for VM SKU availability and ensures that the VM size can be customized via environment parameters. The most important changes are grouped below:VM Size Default and Customization
Standard_DS2_v2toStandard_D2s_v5in bothinfra/main.bicepandinfra/main_custom.bicep, as well as in the ARM template output (infra/main.json). This provides a more current, cost-effective, and widely available VM option. [1] [2] [3]AZURE_ENV_VM_SIZEparameter to documentation and deployment templates, allowing users to override the default VM size for production deployments. [1] [2]Documentation and Troubleshooting Improvements
SkuNotAvailableerror, including guidance on checking SKU availability, recommended alternatives, and explicit advice to avoid unsupported VM series.infra/modules/virtualNetwork.bicepto reflect the new default and clarify recommended options.Template and Dependency Updates
infra/main.jsonfor consistency with the new deployment configuration. [1] [2] [3]infra/main.jsonfor private DNS zones, ensuring correct deployment sequencing. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information