Skip to content

Enable DYNAMIC_INSTRUCTIONS_RETRIEVAL#1298

Open
JasonYeMSFT wants to merge 1 commit intomicrosoft:mainfrom
JasonYeMSFT:chuye/dynamic-instructions-retrieval
Open

Enable DYNAMIC_INSTRUCTIONS_RETRIEVAL#1298
JasonYeMSFT wants to merge 1 commit intomicrosoft:mainfrom
JasonYeMSFT:chuye/dynamic-instructions-retrieval

Conversation

@JasonYeMSFT
Copy link
Copy Markdown
Member

@JasonYeMSFT JasonYeMSFT commented Mar 16, 2026

@JasonYeMSFT JasonYeMSFT marked this pull request as ready for review March 16, 2026 17:48
Copilot AI review requested due to automatic review settings March 16, 2026 17:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Collaborator

@jongio jongio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good - follows the existing env var pattern and CI is green.

One issue: this branch was forked before SKILL_CHAR_BUDGET: "20000" was added to the same env block on main. Merging will conflict. Rebase on main so the result includes all three env vars (SKILLS_INSTRUCTIONS, DYNAMIC_INSTRUCTIONS_RETRIEVAL, SKILL_CHAR_BUDGET).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants