fix: update default VM size and update documentation for the same#850
Open
Harsh-Microsoft wants to merge 2 commits intodev-v4from
Open
fix: update default VM size and update documentation for the same#850Harsh-Microsoft wants to merge 2 commits intodev-v4from
Harsh-Microsoft wants to merge 2 commits intodev-v4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces a new configurable parameter for virtual machine size across the deployment templates and documentation, improving flexibility and clarity for users. The default VM size is now set to
Standard_D2s_v5, and related troubleshooting documentation has been updated to reflect this change and provide guidance for SKU errors and accelerated networking support.Parameterization and default value changes:
virtualMachineSizetoinfra/main.bicepandinfra/main.json, with a default value ofStandard_D2s_v5, allowing users to override the VM size used for jumpbox deployments. [1] [2]infra/main.waf.parameters.jsonto accept and pass through theAZURE_ENV_VM_SIZEenvironment variable.Documentation updates:
AZURE_ENV_VM_SIZEto the environment variable table indocs/CustomizingAzdParameters.md, describing its purpose and default value.docs/TroubleShootingSteps.mdfor SKU availability errors and accelerated networking, including recommendations and notes about the new default VM size. [1] [2]Template and metadata updates:
infra/main.jsonto reflect the new Bicep version and changes. [1] [2] [3] [4] [5] [6] [7]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information