Skip to content

fix: update default VM size and update documentation for the same#850

Open
Harsh-Microsoft wants to merge 2 commits intodev-v4from
hb-psl-us-36353
Open

fix: update default VM size and update documentation for the same#850
Harsh-Microsoft wants to merge 2 commits intodev-v4from
hb-psl-us-36353

Conversation

@Harsh-Microsoft
Copy link
Contributor

Purpose

This pull request introduces a new configurable parameter for virtual machine size across the deployment templates and documentation, improving flexibility and clarity for users. The default VM size is now set to Standard_D2s_v5, and related troubleshooting documentation has been updated to reflect this change and provide guidance for SKU errors and accelerated networking support.

Parameterization and default value changes:

  • Added a new parameter virtualMachineSize to infra/main.bicep and infra/main.json, with a default value of Standard_D2s_v5, allowing users to override the VM size used for jumpbox deployments. [1] [2]
  • Updated the deployment logic to reference the parameterized VM size instead of a hardcoded value, ensuring consistency across ARM/Bicep templates. [1] [2]
  • Updated infra/main.waf.parameters.json to accept and pass through the AZURE_ENV_VM_SIZE environment variable.

Documentation updates:

  • Added AZURE_ENV_VM_SIZE to the environment variable table in docs/CustomizingAzdParameters.md, describing its purpose and default value.
  • Enhanced troubleshooting steps in docs/TroubleShootingSteps.md for SKU availability errors and accelerated networking, including recommendations and notes about the new default VM size. [1] [2]

Template and metadata updates:

  • Updated Bicep-generated metadata and template hashes in infra/main.json to reflect the new Bicep version and changes. [1] [2] [3] [4] [5] [6] [7]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant