fix: codeQL fix for raising the error#861
Merged
Roopan-Microsoft merged 2 commits intodev-v4from Mar 17, 2026
Merged
Conversation
Dhruvkumar-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
dgp10801,
marktayl1,
nchandhi and
toherman-msft
as code owners
Dhruvkumar-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Improves error handling in the v4 orchestration HumanApprovalManager completion flow by attempting to surface a clearer failure when the agent cannot complete after retrying.
Changes:
- Adds a final
RuntimeErrorintended to trigger after_complete()exhausts all retry attempts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+135
to
+138
| # If we get here, all retry attempts have been exhausted without a successful response. | ||
| raise RuntimeError( | ||
| f"Agent failed to complete after {max_retries} attempts due to repeated errors." | ||
| ) |
Comment on lines
+137
to
+138
| f"Agent failed to complete after {max_retries} attempts due to repeated errors." | ||
| ) |
Comment on lines
+135
to
+138
| # If we get here, all retry attempts have been exhausted without a successful response. | ||
| raise RuntimeError( | ||
| f"Agent failed to complete after {max_retries} attempts due to repeated errors." | ||
| ) |
Dhruvkumar-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Roopan-Microsoft
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request adds improved error handling to the
human_approval_manager.pyorchestration logic. Now, if all retry attempts fail when completing a task, the code will raise a clear exception instead of silently failing.Error handling improvements:
RuntimeErrorthat is raised after all retry attempts are exhausted in the_completemethod, providing a clear error message when the agent fails to complete due to repeated errors.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information