fix: add __init__ to CIEvoStr to fix missing scen argument TypeError (#1329)#1346
Open
mango766 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: add __init__ to CIEvoStr to fix missing scen argument TypeError (#1329)#1346mango766 wants to merge 1 commit intomicrosoft:mainfrom
mango766 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
CIEvoStr() was called without arguments but its parent class EvolvingStrategy.__init__ requires a `scen: Scenario` parameter, causing an immediate TypeError on startup. CIEvoStr doesn't use self.scen anywhere, so override __init__ to set self.scen = None without requiring a Scenario instance. Fixes microsoft#1329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
TypeError: EvolvingStrategy.__init__() missing 1 required positional argument: 'scen'when runningrdagent/app/CI/run.py.Root cause
CIEvoStr()on line 729 is called without arguments, but the parent classEvolvingStrategy.__init__requires ascen: Scenarioparameter.CIEvoStrnever usesself.scen, so the CI script has no scenario to pass.Fix
Override
__init__inCIEvoStrto setself.scen = Nonewithout requiring aScenarioinstance.Fixes #1329
📚 Documentation preview 📚: https://RDAgent--1346.org.readthedocs.build/en/1346/