Skip to content

fix: preserve default Docker extra_volumes in factor/model envs (#1428) #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utsab345 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve default Docker extra_volumes in factor/model envs (#1428) #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rdagent/components/coder/factor_coder/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,15 @@ class FactorCoSTEERSettings(CoSTEERSettings):

def get_factor_env(
conf_type: Optional[str] = None,
extra_volumes: dict = {},
extra_volumes: Optional[dict] = None,
running_timeout_period: int = 600,
enable_cache: Optional[bool] = None,
) -> Env:
conf = FactorCoSTEERSettings()
if hasattr(conf, "python_bin"):
env = LocalEnv(conf=(CondaConf(conda_env_name=os.environ.get("CONDA_DEFAULT_ENV"))))
env.conf.extra_volumes = extra_volumes.copy()
if extra_volumes is not None:
env.conf.extra_volumes = extra_volumes.copy()
env.conf.running_timeout_period = running_timeout_period
if enable_cache is not None:
env.conf.enable_cache = enable_cache
Expand Down
5 changes: 3 additions & 2 deletions rdagent/components/coder/model_coder/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class ModelCoSTEERSettings(CoSTEERSettings):

def get_model_env(
conf_type: Optional[str] = None,
extra_volumes: dict = {},
extra_volumes: Optional[dict] = None,
running_timeout_period: int = 600,
enable_cache: Optional[bool] = None,
) -> Env:
Expand All @@ -27,7 +27,8 @@ def get_model_env(
else:
raise ValueError(f"Unknown env type: {conf.env_type}")

env.conf.extra_volumes = extra_volumes.copy()
if extra_volumes is not None:
env.conf.extra_volumes = extra_volumes.copy()
env.conf.running_timeout_period = running_timeout_period
if enable_cache is not None:
env.conf.enable_cache = enable_cache
Expand Down
Loading