fix: restrict MCTSScheduler leaf selection to available DAG leaves (#1429)#1437
Open
utsab345 wants to merge 1 commit into
Open
fix: restrict MCTSScheduler leaf selection to available DAG leaves (#1429)#1437utsab345 wants to merge 1 commit into
utsab345 wants to merge 1 commit into
Conversation
…_status The old code used list(set(range(len(trace.hist)))) as available leaves, which includes internal (already-expanded) nodes and ignores uncommited_rec_status. This caused two bugs: 1. MCTS expanded internal nodes instead of actual DAG leaves 2. Parallel workers could re-expand the same in-flight leaf Fix mirrors the pattern used by RoundRobinScheduler and ProbabilisticScheduler: trace.get_leaves() filtered by uncommited_rec_status[leaf] == 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1429.
This PR updates
MCTSScheduler.select()to follow the same leaf-selection semantics as the existingRoundRobinSchedulerandProbabilisticScheduler.Changes
trace.histindices with the actual DAG leaves returned bytrace.get_leaves().uncommited_rec_status.Why
Previously,
MCTSScheduler.select()constructed its candidate set using every index intrace.hist, which caused two issues:This implementation now mirrors the behavior of the sibling schedulers while keeping the remainder of the MCTS selection logic unchanged.
Testing
Verified the following:
uncommited_rec_statusare never selected.This change is intentionally minimal and only affects the construction of the candidate leaf set.
📚 Documentation preview 📚: https://RDAgent--1437.org.readthedocs.build/en/1437/