Refactor SessionWindowPipe to use Queue instead of LinkedList #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wassim-k
force-pushed
the
session-window-pipe-queue
branch
from
837b4f1 to
3a64b96
Compare
wassim-k
force-pushed
the
session-window-pipe-queue
branch
from
3a64b96 to
bc9338f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance of
SessionTimeoutWindowdegrades rapidly with large data stream due to the internalLinkedListgrowing in size and the linearFindmethod on the list slowing down over time for sessions with longer timeout.This PR replaces
LinkedListwith aQueue, this change improves performance by up to 100x for large data streams.All tests pass.