Add tests around capturing logs from DistributedApplicationBuilder on failures by afscrome · Pull Request #15266 · microsoft/aspire

afscrome · 2026-03-15T22:21:26Z

Description

This PR adds some test cases around making sure that logs get properly written on various resource failure cases. These have had a habit of workign fine one release, then breaking the next so adding these tests should help prevent regressions. (Or at least ensure changes are being made intentionally)

Note, some tests are commented that ought to pass, but don't due to other bugs:

Fixes #14262

Checklist

Is this feature complete?
- Yes. Ready to ship.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
Did you add public API?
- No
Does the change make any security assumptions or guarantees?
- No
Does the change require an update in our Aspire docs?
- No

… failures Note, some tests are commented that ought to pass, but don't due to various issues. - microsoft#13760 - microsoft#14262 - microsoft#10218 (comment) - microsoft#13756

github-actions · 2026-03-15T22:21:35Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15266

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15266"

Copilot

Pull request overview

Adds new test coverage to validate resource failure logging behavior for executable and container resources, ensuring stdout/stderr and common startup failures are surfaced via resource logging.

Changes:

Add ExecutableResourceFailureLoggingTests to assert log forwarding when an executable exits immediately.
Add ContainerResourceFailureLoggingTests to assert log forwarding on common Docker startup failures (bad args/image/auth).
Include shared AsyncTestHelpers.cs in Aspire.Hosting.Containers.Tests to enable DefaultTimeout helpers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
tests/Aspire.Hosting.Tests/ResourceFailureLoggingTests.cs	New executable-resource logging test and helper methods for collecting forwarded log lines
tests/Aspire.Hosting.Containers.Tests/ResourceFailureLoggingTests.cs	New container-resource logging tests for common failure scenarios and log extraction helper
tests/Aspire.Hosting.Containers.Tests/Aspire.Hosting.Containers.Tests.csproj	Adds shared AsyncTestHelpers compile include needed by new tests

+using Microsoft.AspNetCore.InternalTesting;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging.Testing;


+        var container = builder.AddExecutable("pwsh", "pwsh", "")
+            .WithArgs("-Command", """
+                Write-Host "Hello from Stdout"
+                [Console]::Error.WriteLine("Hello from Stderr")
+                """);
+        AddFakeLogging(container);
+
+        FakeLogCollector logCollector;
+        using (var app = builder.Build())
+        {
+            logCollector = app.Services.GetFakeLogCollector();
+            await app.StartAsync(cts.Token).DefaultTimeout(TestConstants.DefaultOrchestratorTestLongTimeout);
+            await app.ResourceNotifications.WaitForResourceAsync(container.Resource.Name, KnownResourceStates.Finished, cts.Token).DefaultTimeout(TestConstants.DefaultOrchestratorTestLongTimeout);


+using Aspire.TestUtilities;
+using Microsoft.AspNetCore.InternalTesting;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging;


+        var cts = CancellationTokenSource.CreateLinkedTokenSource(TestContext.Current.CancellationToken);
+        cts.CancelAfter(TimeSpan.FromMinutes(1));
+        return cts;


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

adamint · 2026-03-16T17:36:07Z

+    [Fact]
+    [RequiresFeature(TestFeature.Docker)]
+    // https://github.com/dotnet/aspire/issues/13756
+    public async Task IllegalBindMount()


why is this commented out?

Remove commented-out tests that were blocked by known issues: - IllegalBindMount (microsoft#13756) - ContainerExitsImmediatelyAfterStart (microsoft#14262) - ExecutableDoesNotExist (microsoft#10218) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The exact Docker daemon error message varies across environments. Use Contains("Error response from daemon") for a more robust assertion, consistent with the BadImage test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-03-27T06:53:55Z

Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Hosting-1 / Hosting-1 (windows-latest) - Job-level runner or infrastructure failure matched the transient allowlist.

… failures (microsoft#15266) * Add tests around capturing logs from DistributedApplicationBuilder on failures Note, some tests are commented that ought to pass, but don't due to various issues. - microsoft#13760 - microsoft#14262 - microsoft#10218 (comment) - microsoft#13756 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Copilot feedback * Merge main and remove commented-out tests Remove commented-out tests that were blocked by known issues: - IllegalBindMount (microsoft#13756) - ContainerExitsImmediatelyAfterStart (microsoft#14262) - ExecutableDoesNotExist (microsoft#10218) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix NeedsAuthentication assertion to use Contains instead of EndsWith The exact Docker daemon error message varies across environments. Use Contains("Error response from daemon") for a more robust assertion, consistent with the BadImage test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Mitch Denny <mitch@mitchdeny.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add tests around capturing logs from DistributedApplicationBuilder on…

e43bfb3

… failures Note, some tests are commented that ought to pass, but don't due to various issues. - microsoft#13760 - microsoft#14262 - microsoft#10218 (comment) - microsoft#13756

afscrome requested a review from mitchdenny as a code owner March 15, 2026 22:21

Copilot AI review requested due to automatic review settings March 15, 2026 22:21

dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Mar 15, 2026

Copilot started reviewing on behalf of afscrome March 15, 2026 22:22 View session

Copilot AI reviewed Mar 15, 2026

View reviewed changes

afscrome and others added 2 commits March 15, 2026 22:31

Potential fix for pull request finding

72e3c45

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot feedback

da7dc57

afscrome force-pushed the executable-log-tests branch from 075e00d to da7dc57 Compare March 15, 2026 23:06

github-actions Bot mentioned this pull request Mar 16, 2026

[pull requests] Review required #13834

Closed

adamint reviewed Mar 16, 2026

View reviewed changes

Mitch Denny and others added 2 commits March 27, 2026 16:25

Merge remote-tracking branch 'origin/main' into executable-log-tests

429ced9

mitchdenny approved these changes Mar 27, 2026

View reviewed changes

mitchdenny merged commit 046a63b into microsoft:main Mar 27, 2026
507 of 510 checks passed

joperezr added this to the 13.3 milestone Apr 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests around capturing logs from DistributedApplicationBuilder on failures#15266

Add tests around capturing logs from DistributedApplicationBuilder on failures#15266
mitchdenny merged 6 commits intomicrosoft:mainfrom
afscrome:executable-log-tests

afscrome commented Mar 15, 2026

Uh oh!

github-actions Bot commented Mar 15, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

adamint Mar 16, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

afscrome commented Mar 15, 2026

Description

Checklist

Uh oh!

github-actions Bot commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

adamint Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Mar 15, 2026 •

edited

Loading