Feat: devcontainer pytest integration #110
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,62 +1,81 @@ | ||
| # Azure DevOps pipeline for CI (Microsoft-hosted version) | ||
| # As the Microsoft-hosted agent option has a limit of 10GB of storage for disk outputs from a pipeline, | ||
| # this causes an issue when the Docker images for modules under src require more than 10GB of storage. | ||
| # If you will run into space issues (or other limitations with a Microsoft hosted agent option outlined in | ||
| # https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#capabilities-and-limitations), | ||
| # consider using the .azuredevops/ado-ci-pipeline-self-hosted.yml version or using scale set agents, see | ||
| # this link for more info: https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/scale-set-agents?view=azure-devops | ||
| # Note that docker images will only be build for src directories that contain at least one test file, so the | ||
| # total space consumed by Docker builds will be dependent on which modules under src contain tests. | ||
| # For setting up the pipeline in ADO see: | ||
| # https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/pools-queues?view=azure-devops&tabs=yaml%2Cbrowser | ||
| # | ||
| # Templates are located in .azuredevops/templates/ | ||
|
|
||
| trigger: | ||
| - main | ||
|
|
||
| stages: | ||
| - stage: Lint | ||
| displayName: 'Lint' | ||
| jobs: | ||
| - job: RunLinter | ||
| displayName: 'Run ruff linter' | ||
| pool: | ||
| vmImage: 'ubuntu-latest' | ||
|
Comment on lines
+24
to
+25
Member
There was a problem hiding this comment. I see every stage uses the same pool. so should we stick with the previous design where we define it once for all? |
||
| steps: | ||
| - task: UsePythonVersion@0 | ||
| displayName: 'Use Python 3.11' | ||
| inputs: | ||
| versionSpec: 3.11 | ||
|
|
||
| - script: | | ||
| python -m venv venv | ||
| source venv/bin/activate | ||
| python -m pip install --upgrade pip | ||
| pip install -r requirements-dev.txt | ||
| displayName: 'Install requirements' | ||
|
|
||
| - bash: | | ||
| source venv/bin/activate | ||
| ruff check --output-format azure | ||
| displayName: 'Run ruff linter' | ||
|
|
||
| - stage: Test | ||
| displayName: 'Test Devcontainers' | ||
| jobs: | ||
| - template: templates/test-devcontainer-job.yml | ||
| parameters: | ||
| projects: | ||
| - name: 'cpu-project' | ||
| configPath: 'src/sample_cpu_project/.devcontainer/devcontainer.json' | ||
| projectPath: 'src/sample_cpu_project' | ||
| - name: 'gpu-project' | ||
| configPath: 'src/sample_pytorch_gpu_project/.devcontainer/devcontainer.json' | ||
| projectPath: 'src/sample_pytorch_gpu_project' | ||
| - name: 'notebooks' | ||
| configPath: 'notebooks/.devcontainer/devcontainer.json' | ||
| projectPath: 'notebooks' | ||
| smokeTestOnly: true | ||
| pool: | ||
| vmImage: 'ubuntu-latest' | ||
|
|
||
| - job: PublishCoverage | ||
| displayName: 'Publish Coverage' | ||
junkataoka marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # NOTE: test-devcontainer-job.yml creates one job per project with the name pattern: | ||
| # Test_<project-name-with-hyphens-replaced-by-underscores> | ||
| # For the projects defined above: | ||
| # - cpu-project -> Test_cpu_project | ||
| # - gpu-project -> Test_gpu_project | ||
| # - notebooks -> Test_notebooks | ||
| # If you change a project name, update the corresponding entry here to match this convention. | ||
| dependsOn: [Test_cpu_project, Test_gpu_project, Test_notebooks] | ||
| condition: succeededOrFailed() | ||
| pool: | ||
| vmImage: 'ubuntu-latest' | ||
| steps: | ||
| - template: templates/merge-coverage.yml | ||
| parameters: | ||
| coverageArtifacts: | ||
| - 'coverage-cpu-project' | ||
| - 'coverage-gpu-project' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,82 +1,62 @@ | ||
| # Azure DevOps CI Pipeline (Self-Hosted Agent) | ||
| # | ||
|
Member
There was a problem hiding this comment. this 10GB part was the reason why we needed two different yamls. Could you check if it's ok to delete this part? If we still have this restriction, we likely need some cleanup method we had for self-hosted version specifically |
||
| # This pipeline runs on self-hosted agents and supports both Linux and macOS (Apple Silicon). | ||
| # Templates are located in .azuredevops/templates/ | ||
|
|
||
| trigger: | ||
| - main | ||
|
|
||
| stages: | ||
| - stage: Lint | ||
| displayName: 'Lint' | ||
| jobs: | ||
| - job: RunLinter | ||
| displayName: 'Run ruff linter' | ||
| pool: | ||
| name: Default | ||
| workspace: | ||
| clean: all | ||
| steps: | ||
| - script: | | ||
| python3 -m venv venv | ||
| source venv/bin/activate | ||
| pip install --upgrade pip | ||
| pip install -r requirements-dev.txt | ||
| displayName: 'Install requirements' | ||
|
|
||
| - bash: | | ||
| source venv/bin/activate | ||
| ruff check --output-format azure | ||
| displayName: 'Run ruff linter' | ||
|
|
||
| - stage: Test | ||
| displayName: 'Test Devcontainers' | ||
| jobs: | ||
| - template: templates/test-devcontainer-job.yml | ||
| parameters: | ||
| projects: | ||
| - name: 'cpu-project' | ||
| configPath: 'src/sample_cpu_project/.devcontainer/devcontainer.json' | ||
| projectPath: 'src/sample_cpu_project' | ||
| - name: 'gpu-project' | ||
| configPath: 'src/sample_pytorch_gpu_project/.devcontainer/devcontainer.json' | ||
| projectPath: 'src/sample_pytorch_gpu_project' | ||
| - name: 'notebooks' | ||
| configPath: 'notebooks/.devcontainer/devcontainer.json' | ||
| projectPath: 'notebooks' | ||
| smokeTestOnly: true | ||
| pool: | ||
| name: Default | ||
|
|
||
| - job: PublishCoverage | ||
| displayName: 'Publish Coverage' | ||
junkataoka marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dependsOn: [Test_cpu_project, Test_gpu_project, Test_notebooks] | ||
| condition: succeededOrFailed() | ||
| pool: | ||
| name: Default | ||
| steps: | ||
| - template: templates/merge-coverage.yml | ||
| parameters: | ||
| coverageArtifacts: | ||
| - 'coverage-cpu-project' | ||
| - 'coverage-gpu-project' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| parameters: | ||
| - name: coverageArtifacts | ||
| type: object | ||
| default: [] | ||
|
|
||
| steps: | ||
| - checkout: none | ||
|
|
||
| - ${{ each artifact in parameters.coverageArtifacts }}: | ||
| - task: DownloadPipelineArtifact@2 | ||
| inputs: | ||
| artifact: '${{ artifact }}' | ||
| path: '$(Pipeline.Workspace)/coverage/${{ artifact }}' | ||
| continueOnError: true | ||
|
|
||
| - bash: | | ||
| set -ex | ||
|
|
||
| # Install .NET SDK | ||
| ARCH_FLAG="" | ||
| [[ "$(uname -m)" == "arm64" ]] && ARCH_FLAG="--architecture arm64" | ||
| curl -sSL https://dot.net/v1/dotnet-install.sh | bash /dev/stdin --channel 8.0 --install-dir $HOME/.dotnet $ARCH_FLAG | ||
|
|
||
| # Make .NET available for subsequent tasks | ||
| echo "##vso[task.prependpath]$HOME/.dotnet" | ||
| echo "##vso[task.prependpath]$HOME/.dotnet/tools" | ||
| displayName: 'Install .NET SDK' | ||
|
|
||
| - bash: | | ||
| set -ex | ||
|
|
||
| export DOTNET_ROOT=$HOME/.dotnet | ||
| export PATH="$DOTNET_ROOT:$DOTNET_ROOT/tools:$PATH" | ||
|
|
||
| # Install ReportGenerator | ||
| dotnet tool install -g dotnet-reportgenerator-globaltool 2>/dev/null || dotnet tool update -g dotnet-reportgenerator-globaltool | ||
|
|
||
| # Find and merge coverage files | ||
| COVERAGE_FILES=$(find $(Pipeline.Workspace)/coverage -name "coverage.xml" 2>/dev/null | paste -sd ";" -) | ||
| if [ -z "$COVERAGE_FILES" ]; then | ||
| echo "##vso[task.logissue type=error]No coverage files found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Merging coverage files: $COVERAGE_FILES" | ||
| mkdir -p $(Pipeline.Workspace)/coverage/merged | ||
| reportgenerator \ | ||
| "-reports:$COVERAGE_FILES" \ | ||
| "-targetdir:$(Pipeline.Workspace)/coverage/merged" \ | ||
| "-reporttypes:Cobertura;HtmlInline_AzurePipelines" | ||
| displayName: 'Merge coverage reports' | ||
|
|
||
| - task: PublishCodeCoverageResults@2 | ||
| inputs: | ||
| summaryFileLocation: '$(Pipeline.Workspace)/coverage/merged/Cobertura.xml' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Template: Publish Test Results | ||
| # Publishes test results and coverage artifacts from a project | ||
| # | ||
| # Parameters: | ||
| # projectPath: Path to project directory containing test-results.xml and coverage.xml | ||
| # projectName: Name for the test run and coverage artifact | ||
|
|
||
| parameters: | ||
| - name: projectPath | ||
| type: string | ||
| - name: projectName | ||
| type: string | ||
|
|
||
| steps: | ||
| - task: PublishTestResults@2 | ||
| inputs: | ||
| testResultsFiles: '${{ parameters.projectPath }}/test-results.xml' | ||
| testRunTitle: '${{ parameters.projectName }}' | ||
| condition: succeededOrFailed() | ||
|
|
||
| - task: PublishPipelineArtifact@1 | ||
| inputs: | ||
| targetPath: '$(System.DefaultWorkingDirectory)/${{ parameters.projectPath }}/coverage.xml' | ||
| artifact: 'coverage-${{ parameters.projectName }}' | ||
| condition: succeededOrFailed() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the reason for diff showing up here? It looks the same?