Conversation
| license = "MIT" | ||
| repository = "https://github.com/microsoft/edit" | ||
| rust-version = "1.88" | ||
| rust-version = "1.93" |
There was a problem hiding this comment.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
There was a problem hiding this comment.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.
| // Licensed under the MIT License. | ||
|
|
||
| use std::hint::cold_path; | ||
| use stdext::cold_path; |
There was a problem hiding this comment.
The PR for stabilizing cold_path was just merged by the Rust team hours ago:
rust-lang/rust#151576
Another PR for the cold_path release notes was just opened with the 1.95.0 milestone:
rust-lang/rust#152251
Rust version 1.95.0 is planned to be stable on April 16, 2026:
https://releases.rs/docs/1.95.0/
| license = "MIT" | ||
| repository = "https://github.com/microsoft/edit" | ||
| rust-version = "1.88" | ||
| rust-version = "1.93" |
There was a problem hiding this comment.
FWIW this is the latest stable version which was released earlier this month. (We could support older versions if we add more shims.)
@lhecker Just curious, why support older versions of Rust? Why shims? Rust always works on all platforms. I think it's more correct to always prefer the Rust std and keep the code concise.
3 participants
This removes:
Closes #44