useResizeHandle: Fix bugs with pointer capture, native drag, and text selection#610
Open
ryantrem wants to merge 5 commits intomicrosoft:mainfrom
Open
useResizeHandle: Fix bugs with pointer capture, native drag, and text selection#610ryantrem wants to merge 5 commits intomicrosoft:mainfrom
ryantrem wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Hello @ryantrem, thank you for finding and fixing these! I was never able to reproduce the second issue you mention, but the fix doesn't seem to break anything for me either. The other two seem to be fixed and I couldn't find any new issues after extensive testing, so lets merge this in. Thanks again |
george-cz
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #523.
Most of the problems stem from using legacy/compatibility events like
mousedownandtouchstart(rather than justpoitnerdown). There are several problems being addressed:mouseupevent is not received and we stay in resize mode.This PR fixes these problems by handling additional events for:
dragstartand simply ignore it.selectstartand ignore it.