fix(calendar-compat): prevent component from crashing if value is undefined#35798
Open
mainframev wants to merge 2 commits intomicrosoft:masterfrom
Open
fix(calendar-compat): prevent component from crashing if value is undefined#35798mainframev wants to merge 2 commits intomicrosoft:masterfrom
mainframev wants to merge 2 commits intomicrosoft:masterfrom
Conversation
📊 Bundle size report
🤖 This report was generated against 80e5e0651f604b7e45a5595c5b8d00b4e34f554f |
|
Pull request demo site: URL |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
change/@fluentui-react-calendar-compat-cf21ab21-bd90-4ae4-972d-ec1c9888ee2f.json
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Calendar to prevent crashes by checking if
selectedDateexists before using it, and by defaultingselectedDateandnavigatedDaytotodayif they are undefinedPrevious Behavior
explicit undefined crashing component
New Behavior
Added
selectedDateguard to the formatter conditional so dateStringFormatter is never called with undefined. Replaced selectedDate! non-null assertion with selectedDate ?? todayRelated Issue(s)