Open
Conversation
olafura
requested review from
MIchaelMainer,
Ndiritu,
andrueastman,
baywet,
calebkiage,
peombwa,
rkodev and
zengin
as code owners
|
baywet
requested changes
Feb 7, 2024
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution, can you also please:
- bump the patch version
- add a changelog entry
- add a unit test to prevent regressions
| def write_enum_value(key, values) | ||
| self.write_string_value(key, values.to_s) | ||
| def write_enum_value(key, value) | ||
| self.write_string_value(key, value) |
Member
There was a problem hiding this comment.
Suggested change
| self.write_string_value(key, value) | |
| self.write_string_value(key, value.to_s) unless value.nil? |
What do you think about this alternative?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour transforms a nil into a string before passing it into the
write_string_valuemethod.That means that default value get an empty string. Looking at the documentation Enums are strings and not a list of values.
microsoft/kiota#4146