Reuse utilities from backfill-hasher#1030
Merged
ecraig12345 merged 1 commit intomicrosoft:masterfrom Feb 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes in microsoft/backfill#567, lage can reuse a couple utilities from
backfill-hasherinstead of duplicating them (its dependency on@rushstack/package-deps-hashhas been removed).Also update comments in various docs with more details about if/why the lock file might need to be included in
environmentGlob... I realized after accidentally ending up looking into the logic ofworkspace-toolsparseLockFilethat it's incredibly buggy: outright missing support for newer pnpm versions, and won't work quite as expected in various scenarios even with yarn. So basically while lage intends to be smart about detecting and hashing changes based on the lock file, this is very unlikely to work reliably in reality, so invalidating the cache on all lock file changes is safer.