Skip to content

Fix undefined behavior in __pointer_get_max_taggable #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: public
Choose a base branch
from
Open

Fix undefined behavior in __pointer_get_max_taggable #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/0xc/std/pointer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ ptrtag_t
__pointer_get_max_taggable(void)
{
size_t total = POINTER_TAG_BITS_HI + POINTER_TAG_BITS_LO;
return (ptrtag_t)((1 << total) - 1);
return (ptrtag_t)((1ULL << total) - 1);
Copy link
Copy Markdown
Contributor

@SIGFUN SIGFUN May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptrtag_t is a uint32_t, should we instead be doing (ptrtag_t)1?

}

tagptr_t
Expand Down