fix(docx): resolve math converter crash on empty runs in OMML to LaTeX#2204
Open
saitejabandaru-in wants to merge 1 commit into
Open
fix(docx): resolve math converter crash on empty runs in OMML to LaTeX#2204saitejabandaru-in wants to merge 1 commit into
saitejabandaru-in wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2188.
Root Cause
In
omml.py, thedo_rfunction retrieves text from a math run element viaelm.findtext("./{0}t".format(OMML_NS)). If a math run (<m:r>) has formatting properties (<m:rPr/>) but no<m:t>text child (which some Word editors or copy-pasted equations produce),findtext()returnsNone.Attempting to iterate over
None(for s in None) raisesTypeError: 'NoneType' object is not iterable.Because math preprocessing in
pre_process_docx()runs on the entiredocument.xmlfile in a single try-except block, a single crash indo_rsilently drops all equations in the document, falling back to original unconverted XML.Changes
Nonereturn values indo_r()before iteration.test_docx_empty_math_run) intest_module_misc.pyusing a mock XML structure to verify the fix works and prevents regressions.