Update DotProduct impl to use TensorPrimitives in ToolDescriptionEvaluator#1628
Open
anannya03 wants to merge 1 commit intomicrosoft:mainfrom
Open
Update DotProduct impl to use TensorPrimitives in ToolDescriptionEvaluator#1628anannya03 wants to merge 1 commit intomicrosoft:mainfrom
anannya03 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
anannya03
requested review from
KarishmaGhiya,
g2vinay,
hallipr and
weshaggard
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the DotProduct implementation in the ToolDescriptionEvaluator to use TensorPrimitives.Dot() instead of a manual loop-based calculation. This change simplifies the code and leverages optimized SIMD operations available in TensorPrimitives.
Changes:
- Replaced manual dot product calculation with
TensorPrimitives.Dot()for better performance and code clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update DotProduct impl to use TensorPrimitives in ToolDescriptionEvaluator
The code is working as expected, and result.md is being produced correctly-
GitHub issue number?
#1264
Pre-merge Checklist
servers/Azure.Mcp.Server/CHANGELOG.mdand/orservers/Fabric.Mcp.Server/CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies)