Add code instructions file #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds GitHub Copilot instructions files to help guide AI-assisted code generation for the msticpy project. The instructions provide comprehensive guidance on package structure, code conventions, testing requirements, and development workflows.
Changes:
- Adds
.github/copilot-instructions.mdwith coding guidelines and project conventions - Includes a copy/variant file with additional context about the project
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/copilot-instructions.md | Main Copilot instructions file defining Python standards, testing requirements, and development workflows |
| .github/copilot-instructions copy.md | Extended version with additional project overview and key subpackages information |
However, I've identified several issues with the instructions that need to be corrected:
- Add drop_duplicates(subset=['query']) before merge in get_whois_df to prevent row multiplication from duplicate whois results - Change net_df fixture scope from module to function for test isolation with random sampling - Add autouse fixture to clear LRU caches (get_whois_info, _whois_lookup) between tests to prevent state leakage
…ithub.com/microsoft/msticpy into ianhelle/add-code-instructions-2026-02-01
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copoilot instructions file
Also added fix for sporadic test failures in ip_utils