Open
Conversation
MarcCote
commented
Aug 5, 2021
| def detect(self, observation_text): | ||
| # Spacy has trouble detecting entities ending with \n. | ||
| # Ref: https://github.com/explosion/spaCy/issues/4792#issuecomment-614295948 | ||
| observation_text = observation_text.replace("\n", " ") |
Contributor
Author
There was a problem hiding this comment.
Some issues I found with the latest spacy version.
MarcCote
commented
Aug 5, 2021
|
|
||
| # Get the first observation from the environment. | ||
| obs = env.reset() | ||
| obs, info = env.reset() |
Contributor
Author
There was a problem hiding this comment.
Reflects Jericho's API changes.
MarcCote
commented
Aug 5, 2021
|
|
||
| # Pass the action to the environment. | ||
| new_obs, score, done, info = env.step(action) | ||
| new_obs, reward, done, info = env.step(action) |
Contributor
Author
There was a problem hiding this comment.
The step method now returns the immediate reward instead of the current score.
MarcCote
force-pushed
the
update_readme_and_dependencies
branch
from
5206a12 to
a695ff4
Compare
MarcCote
commented
Aug 11, 2021
|
|
||
| # Monkey patch to remove warning message in fasttext 0.9.2. | ||
| # Ref: https://github.com/facebookresearch/fastText/issues/1067 | ||
| fasttext.FastText.eprint = lambda x: None |
Contributor
Author
There was a problem hiding this comment.
Needed until 0.9.3 comes out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to be tested on more games but so far results can be reproduced for Zork1 and Detective.