Guard removed APIs in TRT 11#28611
Open
kevinch-nv wants to merge 1 commit into
Open
Conversation
Contributor
|
please run |
Signed-off-by: Kevin Chen <kevinch@nvidia.com>
kevinch-nv
force-pushed
the
remove-old-apis-trt-11
branch
from
089cb09 to
fcb8975
Compare
chilo-ms
reviewed
May 21, 2026
| #pragma warning(disable : 4996) | ||
| #endif | ||
| size_t mem_size = trt_engine->getDeviceMemorySize(); | ||
| size_t mem_size = trt_engine->getDeviceMemorySizeV2(); |
Contributor
There was a problem hiding this comment.
Does this API call needs to be guarded as well? as current TRT EP still supports building with older TRT, e.g. TRT 8. We might consider remove the support for TRT 8 though.
Contributor
Author
There was a problem hiding this comment.
I'm OK with removing support for TRT 8
Contributor
There was a problem hiding this comment.
For this PR let's still keep the support for TRT 8 for now as there might be some customers using TRT 8 and we should notice them before we really remove the support.
So i think we should put guard on getDeviceMemorySizeV2 here for TRT >= 10?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TRT 11.0 removes many deprecated APIs, so guard TRT-EP code accordingly to support TRT 11 builds.
Motivation and Context
Fixes compilation with TRT 11.0