Skip to content

Conversation

@hbenl
Copy link
Collaborator

@hbenl hbenl commented Jan 8, 2026

Fixes #38150 and the following tests:

with Chrome/CDP:

  • page/network-request-body.spec.ts:
    • "should get request body for file/blob"
    • "should get request body for navigator.sendBeacon api calls"

with BiDi:

  • page/network-request-body.spec.ts:
    • "should return correct request body buffer for utf-8 body"
    • "should return request body w/o content-type"
    • "should throw on invalid JSON in post data"
    • "should return body for PUT requests"
    • "should get request body for file/blob"
    • "should get request body for navigator.sendBeacon api calls"

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@hbenl
Copy link
Collaborator Author

hbenl commented Jan 8, 2026

The failing BiDi tests are all passing locally. CI test results seem flakier than they used to be, perhaps due to the increased number of workers.

@hbenl hbenl requested a review from yury-s January 9, 2026 08:22
@hbenl hbenl force-pushed the async-request-bodies-2 branch from 403a72b to 07ca85e Compare January 14, 2026 09:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@whimboo
Copy link
Collaborator

whimboo commented Jan 20, 2026

@hbenl mind checking the BiDi job? Two tests are failing - maybe intermittently?

@hbenl hbenl force-pushed the async-request-bodies-2 branch from 07ca85e to d1fbd19 Compare January 20, 2026 12:31
@hbenl
Copy link
Collaborator Author

hbenl commented Jan 20, 2026

Those failures are unrelated to this PR, the tests are also failing in other test runs, I've added them to the expectations file.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@whimboo
Copy link
Collaborator

whimboo commented Jan 20, 2026

Those failures are unrelated to this PR, the tests are also failing in other test runs, I've added them to the expectations file.

Interesting. Do we know since when they started to fail and what caused them given that we were probably green about 4 weeks ago? Or are they new and were not added to the expectation list?

@hbenl
Copy link
Collaborator Author

hbenl commented Jan 20, 2026

Interesting. Do we know since when they started to fail and what caused them given that we were probably green about 4 weeks ago? Or are they new and were not added to the expectation list?

One of them is new and has been failing intermittently from the start, the other started failing on 2026-01-09. I'll investigate.

@hbenl
Copy link
Collaborator Author

hbenl commented Jan 20, 2026

The 2 failures in the latest run are from new tests that have been failing before (one of them intermittently).

@hbenl
Copy link
Collaborator Author

hbenl commented Jan 22, 2026

Hi @yury-s, is there anything holding this PR back from being merged (I did address your review comments)? So far we never merged PRs ourselves, would that be OK once a PR has been approved?

@hbenl hbenl force-pushed the async-request-bodies-2 branch from d1fbd19 to 25f9546 Compare January 23, 2026 10:28
@hbenl
Copy link
Collaborator Author

hbenl commented Jan 23, 2026

  • rebased
  • changed the version for the new feature in the documentation to 1.59
  • added 3 more tests to the expectations file

@hbenl hbenl force-pushed the async-request-bodies-2 branch from 25f9546 to 7af23c6 Compare January 23, 2026 11:02
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "MCP"

12 failed
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-windows-latest
❌ [chrome] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:162 › core › dialog-accept @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [chromium] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [chromium] › mcp/launch.spec.ts:21 › test reopen browser @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [firefox] › mcp/cli.spec.ts:342 › devtools › tracing-start-stop @mcp-macos-15
❌ [webkit] › mcp/cli.spec.ts:267 › save as › screenshot --full-page @mcp-macos-15
❌ [webkit] › mcp/http.spec.ts:263 › http transport shared context @mcp-macos-15
❌ [webkit] › mcp/snapshot-mode.spec.ts:58 › should respect --snapshot-mode=incremental @mcp-macos-15
❌ [webkit] › mcp/test-debug.spec.ts:167 › test_debug (pause/snapshot/resume) @mcp-macos-15

3094 passed, 300 skipped


Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

10 failed
❌ [playwright-test] › runner.spec.ts:124 › should ignore subprocess creation error because of SIGINT @macos-latest-node20
❌ [playwright-test] › reporter-html.spec.ts:1037 › merged › should have link for opening HTML attachments in new tab @macos-latest-node20
❌ [playwright-test] › test-server.spec.ts:178 › start dev server @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:115 › should report api step hierarchy @macos-latest-node20
❌ [playwright-test] › test-step.spec.ts:190 › should not report nested after hooks @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:120 › should update multiple missing snapshots @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:345 › should update multiple files @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:461 › should update when options are specified @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:545 › update-snapshots all › should create new baseline for matching snapshot @macos-latest-node20
❌ [playwright-test] › update-aria-snapshot.spec.ts:592 › update-source-method › should overwrite source @macos-latest-node20

4 flaky ⚠️ [chromium-library] › library/inspector/recorder-api.spec.ts:120 › should type `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1082 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/permissions.spec.ts:115 › permissions › should trigger permission onchange `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:118 › should collapse repeated console messages for test `@ubuntu-latest-node22`

34695 passed, 695 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: add async request.body()

3 participants