-
Notifications
You must be signed in to change notification settings - Fork 132
Connect-PowerBIServiceAccount provide _-Token_ parameter #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
leblocks
merged 7 commits into
master
from
Connect-PowerBIServiceAccount_support_bring_your_own_token_option
Feb 26, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8b8e254
feat(Connect-PowerBIServiceAccount): initial investigation and adding…
e32d569
chore(editorconfig): remove trailing spaces
7c058ea
feat: store AccessToken in a profile
1aabe3f
test(ConnectPowerBIServiceAccount): added UT covering basic auth flow
979b0ac
chore: refactor + remove todos
4bbd7a8
docs: documentation update
d8fa8c5
fix: code review fixes pt.1
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ public class AuthenticationFactorySelector : IAuthenticationFactory | |
| private static IAuthenticationUserFactory UserAuthFactory; | ||
| private static IAuthenticationServicePrincipalFactory ServicePrincipalAuthFactory; | ||
| private static IAuthenticationBaseFactory BaseAuthFactory; | ||
|
|
||
| private void InitializeUserAuthenticationFactory(IPowerBILogger logger, IPowerBISettings settings) | ||
| { | ||
| if (UserAuthFactory == null) | ||
|
|
@@ -76,6 +76,8 @@ public async Task<IAccessToken> Authenticate(IPowerBIProfile profile, IPowerBILo | |
| return await this.Authenticate(profile.UserName, profile.Password, profile.Environment, logger, settings); | ||
| case PowerBIProfileType.Certificate: | ||
| return await this.Authenticate(profile.UserName, profile.Thumbprint, profile.Environment, logger, settings); | ||
| case PowerBIProfileType.BringYourOwnToken: | ||
| return new PowerBIAccessToken { AccessToken = profile.AccessToken, }; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it enough for customer? On the other hand, we return what has been passed in.
leblocks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| default: | ||
| throw new NotSupportedException(); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.