Skip to content

fix: remove RCTCheckForUnregisteredModules #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Saadnajmi merged 1 commit into from
Mar 12, 2026
+0 −65
Merged

fix: remove RCTCheckForUnregisteredModules #2855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions packages/react-native/React/Base/RCTBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,63 +120,6 @@ static void RCTEnsureModuleClassesInitialized(void)
dispatch_queue_create("com.facebook.react.ModuleClassesSyncQueue", DISPATCH_QUEUE_CONCURRENT);
});
}

/**
* Checks for unregistered modules that conform to RCTBridgeModule protocol.
* This detects misconfiguration where external modules are compiled with
* RCT_MODULE_NO_SELF_LOAD=1 but aren't in the moduleClassNames list.
*/
static void RCTCheckForUnregisteredModules(NSArray<Class> *registeredClasses)
{
static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{
NSMutableSet<Class> *registeredSet = [NSMutableSet setWithArray:registeredClasses];

// Get all loaded classes
int numClasses = objc_getClassList(NULL, 0);
if (numClasses <= 0) {
return;
}

Class *classes = (Class *)malloc(sizeof(Class) * numClasses);
numClasses = objc_getClassList(classes, numClasses);

NSMutableArray<NSString *> *unregisteredModules = [NSMutableArray new];

// Check each class that conforms to RCTBridgeModule
for (int i = 0; i < numClasses; i++) {
Class cls = classes[i];

// Skip if already registered
if ([registeredSet containsObject:cls]) {
continue;
}

// Check if class conforms to RCTBridgeModule protocol
if (class_conformsToProtocol(cls, @protocol(RCTBridgeModule))) {
// Skip if it's a core module that will be added
NSString *className = NSStringFromClass(cls);
if ([moduleClassNames containsObject:className]) {
continue;
}

[unregisteredModules addObject:className];
}
}

free(classes);

// Log warning if unregistered modules found
if ([unregisteredModules count] > 0) {
RCTLogWarn(@"⚠️ Detected unregistered RCTBridgeModule classes: %@\n"
@"These modules may have been compiled with RCT_MODULE_NO_SELF_LOAD=1 "
@"but are not in the core moduleClassNames list.\n"
@"To fix: Either compile all modules with RCT_MODULE_NO_SELF_LOAD=0, "
@"or add external modules to moduleClassNames in RCTBridge.mm",
[unregisteredModules componentsJoinedByString:@", "]);
}
});
}
// macOS]

NSArray<Class> *RCTGetModuleClasses(void)
Expand All @@ -201,9 +144,6 @@ static void RCTCheckForUnregisteredModules(NSArray<Class> *registeredClasses)

NSArray<Class> *finalResult = [result copy];

// Check for misconfigured external modules
RCTCheckForUnregisteredModules(finalResult);

return finalResult;
#else
// macOS]
Expand All @@ -212,11 +152,6 @@ static void RCTCheckForUnregisteredModules(NSArray<Class> *registeredClasses)
result = [RCTModuleClasses copy];
});

// [macOS
// Check for misconfigured external modules
RCTCheckForUnregisteredModules(result);
// macOS]

return result;
// [macOS
#endif //RCT_MODULE_NO_SELF_LOAD
Expand Down
Loading