[Secure Boot KEK Update] MiTAC PK-Signed KEK Update#374
Closed
ZitoChung3 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree [company="MiTAC"]
Options:
* (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
* (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
GRDC RDC5 RDD3
Zito Chung | Senior Manager
***@***.***
886 3 5779968 ext. 2689
***@***.***
***@***.***
***@***.***
No. 1, R&D Road 2, Hsinchu Science Park, Hsinchu 308008, Taiwan, R.O.C.
***@***.***
www.mitacmdt.com
***@***.******@***.******@***.******@***.******@***.***
From: microsoft-github-policy-service[bot] ***@***.***>
Sent: Wednesday, March 25, 2026 7:33 PM
To: microsoft/secureboot_objects ***@***.***>
Cc: zito.chung (鍾欣宏 - MDT) ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/secureboot_objects] [Secure Boot KEK Update] MiTAC PK-Signed KEK Update (PR #374)
This email originated from outside of MiTAC group. Do not click links or open attachments unless you recognize the sender and know the content is safe.
[https://avatars.githubusercontent.com/in/95686?s=20&v=4]microsoft-github-policy-service[bot] left a comment (microsoft/secureboot_objects#374)<#374 (comment)>
@ZitoChung3<https://github.com/ZitoChung3> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
* (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
* (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.
1. Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org<http://www.opensource.org>).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
5. Licenses.
* Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
* Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
* Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
1. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
3. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.
—
Reply to this email directly, view it on GitHub<#374?email_source=notifications&email_token=BTH2BZH55F3ZXK2HVJKNZIL4SO7WHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJSGU4DMNBRGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4125864111>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BTH2BZGPZFORM7T6VD42N3L4SO7WHAVCNFSM6AAAAACW6X64ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMRVHA3DIMJRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Contributor
Author
|
@microsoft-github-policy-service agree
* (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="MiTAC"
GRDC RDC5 RDD3
Zito Chung | Senior Manager
***@***.***
886 3 5779968 ext. 2689
***@***.***
***@***.***
***@***.***
No. 1, R&D Road 2, Hsinchu Science Park, Hsinchu 308008, Taiwan, R.O.C.
***@***.***
www.mitacmdt.com
***@***.******@***.******@***.******@***.******@***.***
From: microsoft-github-policy-service[bot] ***@***.***>
Sent: Wednesday, March 25, 2026 7:33 PM
To: microsoft/secureboot_objects ***@***.***>
Cc: zito.chung (鍾欣宏 - MDT) ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/secureboot_objects] [Secure Boot KEK Update] MiTAC PK-Signed KEK Update (PR #374)
This email originated from outside of MiTAC group. Do not click links or open attachments unless you recognize the sender and know the content is safe.
[https://avatars.githubusercontent.com/in/95686?s=20&v=4]microsoft-github-policy-service[bot] left a comment (microsoft/secureboot_objects#374)<#374 (comment)>
@ZitoChung3<https://github.com/ZitoChung3> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
* (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
* (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.
1. Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org<http://www.opensource.org>).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
5. Licenses.
* Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
* Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
* Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.
1. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
3. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.
—
Reply to this email directly, view it on GitHub<#374?email_source=notifications&email_token=BTH2BZH55F3ZXK2HVJKNZIL4SO7WHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMJSGU4DMNBRGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4125864111>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BTH2BZGPZFORM7T6VD42N3L4SO7WHAVCNFSM6AAAAACW6X64ZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCMRVHA3DIMJRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Member
|
@Flickdm I normally sync LVFS when it's merged; would you prefer if I synced after the CLA is signed? |
Member
No thats fine, this is more just an informational message if you didnt see it |
Contributor
Author
|
Do you have an estimated date to merge it to main? |
Member
|
Thanks! It looks like the Other than that your auth variable updates looks like it will be successful! Let me know if you need help with the git commands. Once you do this, I'll approve and get it merged. INFO:root:Validating: KEKUpdate_MiTAC_PK1.bin
INFO:root:Verifying authenticated variable: review/KEKUpdate_MiTAC_PK1.bin
INFO:root:[+] Authenticated variable signature is VALID
INFO:root: Cryptographic Signature: VALID
INFO:root: Expected Payload: True{
"validation_date": "2026-04-01T22:43:41.903144+00:00",
"file": "review/KEKUpdate_MiTAC_PK1.bin",
"parameters": {
"var_name": "KEK",
"var_guid": "8be4df61-93ca-11d2-aa0d-00e098032b8c",
"attributes": "NV,BS,RT,AT,AP"
},
"result": {
"filename": "KEKUpdate_MiTAC_PK1.bin",
"path": "review/KEKUpdate_MiTAC_PK1.bin",
"valid": true,
"payload_hash_valid": true,
"error": null,
"warnings": [],
"details": {
"verified": true
},
"payload_hash": "5b85333c009d7ea55cbb6f11a5c2ff45ee1091a968504c929aed25c84674962f",
"payload_size": 1506
}7e3f66f80384f26b1a4ff6a45c7aecc28891bf1250adbbc3e76bb73868dd70fc review/KEKUpdate_MiTAC_PK1.binINFO:root:Validating: KEKUpdate_MiTAC_PK2.bin
INFO:root:Verifying authenticated variable: review/KEKUpdate_MiTAC_PK2.bin
INFO:root:[+] Authenticated variable signature is VALID
INFO:root: Cryptographic Signature: VALID
INFO:root: Expected Payload: True{
"validation_date": "2026-04-01T22:44:58.663174+00:00",
"file": "review/KEKUpdate_MiTAC_PK2.bin",
"parameters": {
"var_name": "KEK",
"var_guid": "8be4df61-93ca-11d2-aa0d-00e098032b8c",
"attributes": "NV,BS,RT,AT,AP"
},
"result": {
"filename": "KEKUpdate_MiTAC_PK2.bin",
"path": "review/KEKUpdate_MiTAC_PK2.bin",
"valid": true,
"payload_hash_valid": true,
"error": null,
"warnings": [],
"details": {
"verified": true
},
"payload_hash": "5b85333c009d7ea55cbb6f11a5c2ff45ee1091a968504c929aed25c84674962f",
"payload_size": 1506
}
}81246715d79dc04d5bf03c4fd6c45dc6f40e1d389cc47c0ef34211e1e702eb1d review/KEKUpdate_MiTAC_PK2.bin |
Contributor
Author
|
@Flickdm Thanks. |
Flickdm
pushed a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 2, 2026
Flickdm
pushed a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 2, 2026
Flickdm
pushed a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 2, 2026
Flickdm
pushed a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 2, 2026
Flickdm
pushed a commit
that referenced
this pull request
Apr 2, 2026
Flickdm
pushed a commit
that referenced
this pull request
Apr 2, 2026
Member
|
Merged! |
|
I couldn't parse this one for the LVFS upload... I get the wrapper: ...and then the ASN1 doesn't load. |
Contributor
Author
May I know what is the possible root cause? How about the result of KEKUpdate_MiTAC_PK2.bin? Thanks. |
I'm not entirely sure; KEKUpdate_MiTAC_PK2.bin has the exact same failure: |
Member
|
@hughsie Actually I am seeing something odd.. |
Member
AnalysisSo the reason that I don't know which tooling @ZitoChung3 used to create these binaries or which flags - but I should review my own instructions to make sure that this is called out. Most signing tools will natively try to create a signature like ContentInfo ::= SEQUENCE {
contentType id-signedData (1.2.840.113549.1.7.2),
content [0] SignedData { ... }
}Now for reasons I don't understand, when secure boot was first created, they decided to use Now prior to three years ago an Authenticated Variable wrapped in a microsoft/mu_tiano_plus@37d3eb0 What this commit did is any device made and firmware built between 2012-2023 will only support This is why it was successful during testing and why signature validation works (during signature validation we actually have to add the Now if you use the script I include below you will see the following: Hex Comparison19 bytes were removed, and What Changed
The 19 Removed Bytes (offset
|
| Bytes | ASN.1 Meaning |
|---|---|
30 82 05 95 |
SEQUENCE (ContentInfo), length 1429 |
06 09 2a 86 48 86 f7 0d 01 07 02 |
OID 1.2.840.113549.1.7.2 (id-signedData) — identifies this as PKCS#7 Signed Data |
a0 82 05 86 |
[0] EXPLICIT context tag, length 1414 — wraps the SignedData |
In Plain Terms
The .stripped file removes this outer ContentInfo envelope and stores the SignedData SEQUENCE directly as CertData, starting at 30 82 05 82 02 01 01 ... (version=1, ...).
The dwLength field in WIN_CERTIFICATE was also decremented by 19 to reflect the shorter CertData. Everything else (the EFI_TIME, GUID, SignedData contents, and the variable payload) is byte-identical.
Resolution / Recommendations
-
@ZitoChung3 - Are you okay with me creating a new PR that makes these conform to the "most compatible" configuration of ASN.1. This won't require recreating the binaries but just to be safe, would you be willing to rerun the binaries once I strip them and upload them as a PR? (You could also use the script below and do this yourself if you want - or I can do it - its fairly easy)
-
@hughsie - I think I should add a warning but I suspect that since this is valid (for at least new machines) we should think through how we want to handle this moving forward. Its fairly simple to restructure the ASN.1 and as long as the code path is there - both could be supported.
Strip Content Info Script
Member
|
I'm reopening this PR for now until we agree on a resolution |
hughsie
added a commit
to fwupd/fwupd
that referenced
this pull request
Apr 7, 2026
4 tasks
|
I can work around it in fwupd (e.g. fwupd/fwupd#10128) but it's certainly unexpected -- and it's probably a good idea to strip the header for maximum compatibility. |
Member
Yeah I agree - the challenge for the OS is that the OS has no ability to know if the firmware supports this or not. I can see some devices could be built during the time period that I mentioned before where one firmware version does not support |
Contributor
Author
|
@Flickdm Please open new PR, then strip and upload these files. I'm OK to rerun the binaries after that. Thanks. |
Flickdm
added a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 8, 2026
Ref: microsoft#374 These files were uploaded originally with the following ASN.1 structure, which includes an outer `ContentInfo` SEQUENCE: ``` ContentInfo ::= SEQUENCE { contentType id-signedData (1.2.840.113549.1.7.2), content [0] SignedData { ... } } ``` This is problematic because until recently, this was not supported by EDK2 based firmware. microsoft/mu_tiano_plus@37d3eb0 To achieve the most compatibility with existing firmware, the files have been stripped of the outer ContentInfo envelope and stores the **SignedData** SEQUENCE directly as `CertData`, starting at `30 82 05 82 02 01 01 ...` (version=1, ...). The `dwLength` field in `WIN_CERTIFICATE` was also decremented by 19 to |reflect the shorter `CertData`. Everything else (the `EFI_TIME`, GUID, `SignedData` contents, and the variable payload) is byte-identical.
5 tasks
Flickdm
added a commit
to Flickdm/secureboot_objects
that referenced
this pull request
Apr 8, 2026
Ref: microsoft#374 These files were uploaded originally with the following ASN.1 structure, which includes an outer `ContentInfo` SEQUENCE: ``` ContentInfo ::= SEQUENCE { contentType id-signedData (1.2.840.113549.1.7.2), content [0] SignedData { ... } } ``` This is problematic because until recently, this was not supported by EDK2 based firmware. microsoft/mu_tiano_plus@37d3eb0 To achieve the most compatibility with existing firmware, the files have been stripped of the outer ContentInfo envelope and stores the **SignedData** SEQUENCE directly as `CertData`, starting at `30 82 05 82 02 01 01 ...` (version=1, ...). The `dwLength` field in `WIN_CERTIFICATE` was also decremented by 19 to |reflect the shorter `CertData`. Everything else (the `EFI_TIME`, GUID, `SignedData` contents, and the variable payload) is byte-identical.
Member
|
@ZitoChung3 can you test these and once you come back I'll close this? |
Contributor
Author
@Flickdm we have tested it today under Windows and it works fine. Do you know: when does the binaries add into Windows update? |
Flickdm
added a commit
that referenced
this pull request
Apr 9, 2026
Ref: #374 These files were uploaded originally with the following ASN.1 structure, which includes an outer `ContentInfo` SEQUENCE: ``` ContentInfo ::= SEQUENCE { contentType id-signedData (1.2.840.113549.1.7.2), content [0] SignedData { ... } } ``` This is problematic because until recently, this was not supported by EDK2 based firmware. microsoft/mu_tiano_plus@37d3eb0 To achieve the most compatibility with existing firmware, the files have been stripped of the outer ContentInfo envelope and stores the **SignedData** SEQUENCE directly as `CertData`, starting at `30 82 05 82 02 01 01 ...` (version=1, ...). The `dwLength` field in `WIN_CERTIFICATE` was also decremented by 19 to |reflect the shorter `CertData`. Everything else (the `EFI_TIME`, GUID, `SignedData` contents, and the variable payload) is byte-identical.
Member
|
My understanding is that these are being pulled in right now - but I dont specifically know which windows release it will make be in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OEM Certificate Submission
OEM Name: MiTAC
Contact Email: zito.chung@mitacmdt.com
Certificate Details
Testing Completed
Security Review
Additional Notes
Upload two KEK signed by different PK keys: one PK expiration is 2023-04-25, and another is 2043-07-18.