fix: add wait for Storybook Preview API in stepsApi option#77
fix: add wait for Storybook Preview API in stepsApi option#77dmytrokirpa wants to merge 3 commits intomicrosoft:storybook7from
Conversation
|
I think we need to PR against https://github.com/microsoft/storywright/tree/storybook7 that's the only one branch we contributed to which contains modern SB support. also the version bump will be that pre-release manual bump -> please bump those files as well in this PR https://github.com/microsoft/storywright/pull/74/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
|
@Hotell is it ok we keep the version as 0.0.27-storybook7.15 but move the code into storybook8 branch spawned from storybook7 branch? so that it will not create confusion for development and for consumers it can be backword compatible |
the change isn't "breaking", so it's might not make sense to have it in a separate branch or release under |
|
From semver and feature POV it doesn't make sense to create v8 branch as the changes we contributed are compatible across major version of SB (v7 to v9). If we wanna branch and change releases I'd suggest:
|
Added a check to wait for
window["__STORYBOOK_PREVIEW__"]to be available whenoptions.stepsApiis set to"parameters", ensuring that dependent scripts execute only after the Storybook Preview API is ready.This change unblocks the Storybook v8 migration for FluentUI microsoft/fluentui#35279
The problem we encounter atm:
Related to #74