Skip to content

[sqlite3] disable find_package for ICU when SQLITE_ENABLE_ICU is not … #52613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Willieodwyer wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −3
Draft

[sqlite3] disable find_package for ICU when SQLITE_ENABLE_ICU is not … #52613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c1d63
[sqlite3] disable find_package for ICU when SQLITE_ENABLE_ICU is not …
Willieodwyer Jun 26, 2026
dbb55da
Merge branch 'master' into sqlite3-speedup
Willieodwyer Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ports/sqlite3/sqlite3-config.in.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ include(CMakeFindDependencyMacro)
if(NOT WIN32)
find_dependency(Threads)
endif()
if("@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static")
if("@SQLITE_ENABLE_ICU@" AND "@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static")
find_package(ICU COMPONENTS uc i18n)

@dg0yt dg0yt Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: with proper guards, this can become

Suggested change
find_package(ICU COMPONENTS uc i18n)
find_dependency(ICU COMPONENTS uc i18n)

endif()

Expand Down
2 changes: 1 addition & 1 deletion ports/sqlite3/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "sqlite3",
"version": "3.53.2",
"port-version": 1,
"port-version": 2,
"description": "SQLite is a software library that implements a self-contained, serverless, zero-configuration, transactional SQL database engine.",
"homepage": "https://sqlite.org/",
"license": "blessing",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9670,7 +9670,7 @@
},
"sqlite3": {
"baseline": "3.53.2",
"port-version": 1
"port-version": 2
},
"sqlitecpp": {
"baseline": "3.3.3",
Expand Down
5 changes: 5 additions & 0 deletions versions/s-/sqlite3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "2bee2a40a10c46ef424250a20da6860576ba4d19",
"version": "3.53.2",
"port-version": 2
},
{
"git-tree": "2ccab6992dbd68ec1b0ebcb0bb13d92af37c7beb",
"version": "3.53.2",
Expand Down
Loading