Add changes for re running "Deploy to Container App" command by motm32 · Pull Request #999 · microsoft/vscode-azurecontainerapps

motm32 · 2025-12-10T22:57:15Z

This PR adds a couple things:

changes to the deploy to container app command to use an internal function. The command id when deploy to container app is run the first time around gets set directly to the internal command so when copilot re runs this command it goes straight into the internal command (see this rg PR for how that is done)
adds ACA list step and managed environment list steps to the confirmation view

Some things to note

If no subscription is passed in from the activity log items (which there almost always should be) this will revert to the regular deploy flow. I have found that copilot is not very good at picking a subscription.
If there is an error I added logic so the loading view closes.

Things to do:

update and release utils changes

src/commands/createManagedEnvironment/ManagedEnvironmentListStep.ts

src/commands/deployContainerApp/deployContainerApp.ts

nturinski · 2026-01-14T21:55:16Z

src/commands/registryCredentials/identity/ManagedIdentityRegistryCredentialsContext.ts

+import { type ManagedEnvironmentContext } from "../../ManagedEnvironmentContext";

-export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentRequiredContext, IContainerAppContext {
+export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentContext, IContainerAppContext {


Context loosened from ManagedEnvironmentRequiredContext → ManagedEnvironmentContext.
This is fine only if all consumers tolerate managedEnvironment being undefined. Worth a quick scan of downstream usage.

nturinski · 2026-01-14T21:55:50Z

src/commands/deployContainerApp/deployContainerApp.ts

-    wizardContext.telemetry.properties.revisionMode = item.containerApp.revisionsMode;

    const confirmationViewTitle: string = localize('summary', 'Summary');
    let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');


Suggested change

let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');

let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input preceding the changed input will need to change as well');

Wait proceeding is correct here right? It's what comes after that might need to change?

nturinski · 2026-01-14T21:56:20Z

src/commands/deployContainerApp/deployContainerApp.ts

-    if (wizardContext.ui instanceof CopilotUserInput) {
-        promptSteps.push(new OpenLoadingViewStep());
+    if (isCopilotUserInput(wizardContext)) {
        confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');


Suggested change

confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');

confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input preceding the modified input will need to change as well');

src/commands/deployContainerApp/deployContainerApp.ts

nturinski · 2026-03-11T21:23:46Z

src/commands/deployContainerApp/deployContainerApp.ts

+
+        let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;
+
+        if (node && imageSource) {


Can I get some context about this if else if here?

If you have a node and an image source, what does that imply? And if you have a subscription?

node and image source implies you are coming from the regular flow. Just having a subscription and not those other two implies you are coming from a copilot version since we don't pass in a node in that case. I can add comments or something if that is super confusing.

Personally, I think it'd be more readable if you had a flag that says something like: runFromCopilot that's set to true if the subscription is defined or something like that. It just makes it clearer as to why we're checking for it. Maybe add it as a flag up at L68.

+1 I'd love to see Copilot specific logic consolidated as much as possible to improve maintainability of the normal command flow vs. copilot command flow.

MicroFish91 · 2026-03-20T19:58:45Z

src/commands/deployContainerApp/deployContainerApp.ts

+
+        let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;
+
+        if (node && imageSource) {


+1 I'd love to see Copilot specific logic consolidated as much as possible to improve maintainability of the normal command flow vs. copilot command flow.

MicroFish91 · 2026-03-20T20:02:44Z

src/commands/deployContainerApp/deployContainerApp.ts

+
+        const subscription = (context as { azureSubscription?: AzureSubscription }).azureSubscription;
+
+        if (!subscription && !node) {


If I'm understanding this correctly, could this check be consolidated to a section dedicated to Copilot flow specific changes? A brief comment noting that Copilot may sometimes fail to provide a subscription would help make the intent clearer.

MicroFish91 · 2026-03-20T20:06:08Z

src/commands/deployContainerApp/deployContainerApp.ts

+            await openLoadingViewPanel(context);
+        } else {
+            // Prompt for image source before initializing the wizard in case we need to redirect the call to 'deployWorkspaceProject' instead
+            imageSource = await promptImageSource(context);


What was the reason for moving the image source prompt into internal instead of leaving it in the parent function deployContainerApp?

motm32 added 3 commits December 3, 2025 10:10

initial

6179474

fix prompt step issues

6369e45

small change

a73ff7e

motm32 requested a review from a team as a code owner December 10, 2025 22:57

nturinski reviewed Jan 14, 2026

View reviewed changes

src/commands/createManagedEnvironment/ManagedEnvironmentListStep.ts Outdated Show resolved Hide resolved

src/commands/deployContainerApp/deployContainerApp.ts Outdated Show resolved Hide resolved

src/commands/deployContainerApp/deployContainerApp.ts Outdated Show resolved Hide resolved

nturinski reviewed Jan 14, 2026

View reviewed changes

motm32 added 3 commits February 2, 2026 09:47

merge main

28ddbb7

requested changes

3124483

merge main

33b1e64

bwateratmsft reviewed Feb 12, 2026

View reviewed changes

src/commands/deployContainerApp/deployContainerApp.ts Outdated Show resolved Hide resolved

src/commands/deployContainerApp/deployContainerApp.ts Outdated Show resolved Hide resolved

small changes

de898ee

motm32 mentioned this pull request Feb 24, 2026

utils: Changes to enable re running commands with copilot microsoft/vscode-azuretools#2136

Open

motm32 added 4 commits February 24, 2026 14:57

update to use utils

27b145f

more changes

dc140c4

fix loading view

845f2fd

merge main

7dc3606

MicroFish91 reviewed Mar 10, 2026

View reviewed changes

src/commands/deployContainerApp/deployContainerApp.ts Outdated Show resolved Hide resolved

nturinski reviewed Mar 11, 2026

View reviewed changes

rework if statements

8d5ec21

motm32 mentioned this pull request Mar 19, 2026

An error occurs when executing the "Deploy to Container App with Copilot..." command if the "GitHub Copilot Chat" extension is not installed #1052

Open

microsoft deleted a comment from silentsnider-max Mar 20, 2026

MicroFish91 reviewed Mar 20, 2026

View reviewed changes

	let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well');
	let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input preceding the changed input will need to change as well');

	confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well');
	confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input preceding the modified input will need to change as well');


		let wizardContext: ContainerAppDeployContext = {} as ContainerAppDeployContext;

		if (node && imageSource) {


		const subscription = (context as { azureSubscription?: AzureSubscription }).azureSubscription;

		if (!subscription && !node) {

Conversation

motm32 commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicroFish91 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicroFish91 Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MicroFish91 Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

motm32 commented Dec 10, 2025 •

edited

Loading

MicroFish91 Mar 10, 2026 •

edited

Loading

MicroFish91 Mar 20, 2026 •

edited

Loading

MicroFish91 Mar 20, 2026 •

edited

Loading