Draft
Conversation
Contributor
Screenshot ChangesBase: Changed (12)
|
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodos/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithTodosAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/WithArtifactsAndFileChanges/Light
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Dark
| Before | After |
|---|---|
 |
 |
chat/input/chatInput/Full/Light
| Before | After |
|---|---|
 |
 |
chat/chatQuestionCarousel/MultiSelectQuestion/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/SimpleQA/Light
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/PendingToolApproval/Dark
| Before | After |
|---|---|
 |
 |
chat/widget/chatWidget/MultiTurn/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new enhanced telemetry event to capture the request.options.tools payload (tool schema) for Copilot chat requests, intended for third-party telemetry ingestion.
Changes:
- Emit
request.options.toolsenhanced telemetry whenrequest.toolsis present (both websocket and HTTP request paths). - Include request correlation fields (
headerRequestId,conversationId) and serialize the tools array into a JSON field.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/prompt/node/chatMLFetcher.ts | Emits the new request.options.tools enhanced telemetry event in both websocket and HTTP request flows. |
Copilot's findings
Comments suppressed due to low confidence (1)
extensions/copilot/src/extension/prompt/node/chatMLFetcher.ts:1433
- Same as the websocket path:
JSON.stringify(request.tools)can be large (tool schemas), but this enhanced telemetry call doesn’t multiplex/chunk properties, so it can get truncated/dropped. Please usemultiplexProperties(...)(and/or chunking) formessagesJson. Also reconcile themessagesJsonvsmessages_jsonfield naming with the schema referenced in the PR description.
if (request.tools) {
this._telemetryService.sendEnhancedGHTelemetryEvent('request.options.tools', {
headerRequestId: ourRequestId,
conversationId: telemetryProperties?.conversationId,
messagesJson: JSON.stringify(request.tools),
}, telemetryData.measurements);
- Files reviewed: 1/1 changed files
- Comments generated: 2
Comment on lines
+1148
to
+1153
| if (request.tools) { | ||
| this._telemetryService.sendEnhancedGHTelemetryEvent('request.options.tools', { | ||
| headerRequestId: ourRequestId, | ||
| conversationId, | ||
| messagesJson: JSON.stringify(request.tools), | ||
| }, telemetryData.measurements); |
Comment on lines
+1148
to
+1154
| if (request.tools) { | ||
| this._telemetryService.sendEnhancedGHTelemetryEvent('request.options.tools', { | ||
| headerRequestId: ourRequestId, | ||
| conversationId, | ||
| messagesJson: JSON.stringify(request.tools), | ||
| }, telemetryData.measurements); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
request.options.toolsevents to telemetry with the tool schema in the messages_json field.