Sync with OS #609
Open
Sync with OS #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunhor
commented
Jan 17, 2026
| #pragma warning(push) | ||
| // The updated behavior of running init-list ctors during placement new is proper & correct, disable the warning that requests developers verify they want it | ||
| #pragma warning(disable : 4351) | ||
| // remove this after fixing - volatile access of '<expression>' is subject to /volatile:<iso|ms> setting; consider using __iso_volatile_load/store intrinsic functions |
Member
Author
There was a problem hiding this comment.
FYI @jonwis I noticed this when copying the changes
dunhor
commented
Jan 17, 2026
| __pragma(warning(suppress : 4297)); \ | ||
| LOG_CAUGHT_EXCEPTION(); \ | ||
| return; \ | ||
| __pragma(warning(push)) __pragma(warning(disable : 4297)) LOG_CAUGHT_EXCEPTION(); \ |
Member
Author
There was a problem hiding this comment.
Maybe we should update .clang-format to treat __pragma(...) as a full statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been long overdue