chore(events.proto): mark migration post-complete (comment-only)#806
Merged
Conversation
…crumb The opgave→event migration is now complete (Phases 1-4 merged on stable of this repo and master of flutter-eform). Update the proto header: - "Mid-migration" → "Post-migration" - Drop the trailing "Rode rename lands in Phase 4." sentence No wire / message-type / RPC-method changes. Comment-only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the header comment in events.proto to reflect the completion status of the opgave→event-related rename/migration work, without changing any protobuf messages, fields, or RPC definitions.
Changes:
- Adjusts the proto header wording from “Mid-migration” to “Post-migration”.
- Removes the trailing sentence referencing a Phase 4 “Rode” rename.
Comment on lines
+3
to
+7
| // Post-migration: opgave -> event, tavle -> board, ejendom -> property per | ||
| // docs/superpowers/specs/2026-05-11-opgave-to-event-migration.md. | ||
| // Wire field names (`opgaver`, `tavler`, `tavle_id`, `tavle_ids`, | ||
| // `ejendom_id`, `ejendomme`) stay as-is so generated accessors don't churn; | ||
| // only message types and RPC method names move. Rode rename lands in Phase 4. | ||
| // only message types and RPC method names move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only cleanup now that all 4 noun phases of the opgave→event migration are merged on `stable` (Phase 1 #802, Phase 2 #803+#804 promotion, Phase 3 #805) and on flutter-eform `master`.
Two edits to `events.proto` header:
No wire / message-type / RPC-method changes. `response.Ejendomme.Add`/`request.TavleIds`/etc. accessors all unaffected.
🤖 Generated with Claude Code