fix(bboard-cli): resolve config path with fileURLToPath (handles spaces in path)#1473
Open
tomiin wants to merge 1 commit into
Open
fix(bboard-cli): resolve config path with fileURLToPath (handles spaces in path)#1473tomiin wants to merge 1 commit into
tomiin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
bboard-cli/src/config.tsbuildscurrentDirwithnew URL(import.meta.url).pathname. When the project path contains a space, the space stays percent-encoded as %20 (e.g./Users/me/Midnight code/...becomes/Users/me/Midnight%20code/...). That path doesn't exist on disk, so the ZK config lookup fails at runtime withZKConfigurationReadError: Failed to read verifier key.Fix
Use
fileURLToPath(import.meta.url)fromnode:url, which decodes the file URL to a real filesystem path. One-line change plus the import. Fixes the failure for anyone whose checkout lives under a directory with a space in the name.