Skip to content

chore: update tutorial to latest code#1121

Merged
nstanford5 merged 1 commit into
mainfrom
nick-zk-loan
Jul 7, 2026
Merged

chore: update tutorial to latest code#1121
nstanford5 merged 1 commit into
mainfrom
nick-zk-loan

Conversation

@nstanford5

Copy link
Copy Markdown
Contributor

Align the three ZK Loan tutorial files with the example-zkloan repo at the
Midnight JS 4.1.1 / wallet-sdk 1.1.0 state.

smart-contract.mdx:

  • Reword the Node 20 caution to reference the @midnight-ntwrk/wallet-sdk
    barrel instead of the removed wallet-sdk-shielded package.
  • Replace the obsolete "compact-js nested compact-runtime" note with a
    4.1.x protocol-ACL note explaining midnight-js-protocol subpath imports.
  • Rewrite the root package.json snippet: drop direct compact-js and
    ledger-v8 deps, add midnight-js-protocol, collapse the five wallet-sdk-*
    deps to the single @midnight-ntwrk/wallet-sdk barrel, step all
    midnight-js-* to 4.1.1, and pin ledger-v8 to 8.1.0 in
    overrides/resolutions. Add a "what changed vs. 4.0.x" callout.
  • Switch the WitnessContext import to
    @midnight-ntwrk/midnight-js-protocol/compact-runtime.
  • Contract tsconfig: moduleResolution "node" -> "bundler", with an
    explanatory note.

attestation-api.mdx:

  • Rewrite the three @midnight-ntwrk/compact-runtime imports (signing,
    server, index) to use the midnight-js-protocol/compact-runtime subpath.
  • package.json: compact-runtime ^0.16.0, add midnight-js-protocol 4.1.1,
    bump midnight-js-network-id to 4.1.1, with an explanatory note.
  • tsconfig: moduleResolution "node" -> "bundler", with an explanatory note.
  • Fix stale /relnotes/compact-js compatibility-matrix link to
    /relnotes/support-matrix.

@nstanford5 nstanford5 requested review from a team as code owners July 7, 2026 14:13
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
midnight-wiki Ready Ready Preview, Comment Jul 7, 2026 2:18pm

Request Review

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 13
✅ Successful 8
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 5
⛔ Unsupported 0

Errors per input

Errors in docs/tutorials/zk-loan/attestation-api.mdx

  • [ERROR] file:///home/runner/work/midnight-docs/midnight-docs/docs/tutorials/zk-loan/cli | Cannot find file
  • [ERROR] file:///home/runner/work/midnight-docs/midnight-docs/docs/tutorials/zk-loan/smart-contract | Cannot find file

Errors in docs/tutorials/zk-loan/cli.mdx

  • [ERROR] file:///home/runner/work/midnight-docs/midnight-docs/docs/tutorials/zk-loan/attestation-api | Cannot find file
  • [ERROR] file:///home/runner/work/midnight-docs/midnight-docs/docs/tutorials/zk-loan/smart-contract | Cannot find file

Errors in docs/tutorials/zk-loan/smart-contract.mdx

  • [ERROR] file:///home/runner/work/midnight-docs/midnight-docs/docs/tutorials/zk-loan/attestation-api | Cannot find file
    Full Github Actions output

Comment thread docs/tutorials/zk-loan/smart-contract.mdx
Comment thread docs/tutorials/zk-loan/smart-contract.mdx
@nstanford5 nstanford5 merged commit 77af3a1 into main Jul 7, 2026
10 checks passed
@nstanford5 nstanford5 deleted the nick-zk-loan branch July 7, 2026 14:19
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Deployment Ready

🔗 Preview URL: https://pr-1121-midnight-docs.vercel.app

📝 Latest commit: accf89e
Updated: Jul 7, 2026, 2:21 PM UTC


This preview updates automatically when you push new commits to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant