Add "Manager" column to test data for Doug.#169
Open
tvenable-mie wants to merge 1 commit intomainfrom
Open
Conversation
Deploying ui with
|
| Latest commit: |
5e89bd6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://df0104cb.ui-6d0.pages.dev |
| Branch Preview URL: | https://more-datavis-nitro-data.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
Updates the DataVis NITRO Storybook stories and their backing fixture data to include a new manager field/column, enabling demos and testing of a “Manager” column in the employee grid.
Changes:
- Add
managerto the explicitcolumnslist in theDefaultandWithControlsDataVis NITRO stories. - Extend Storybook’s
sample-data.jsonschema (typeInfo) and rows to includemanager, and expand the dataset size.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/components/DataVisNITRO/DataVisNITRO.stories.tsx |
Adds manager to the displayed columns for the main stories that specify columns explicitly. |
.storybook/public/sample-data.json |
Adds manager to typeInfo and provides manager values across an expanded set of sample rows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.