MTA-6288 Centralized configuration through LLM proxy#324
MTA-6288 Centralized configuration through LLM proxy#324
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds an AsciiDoc procedure to enable the LLM proxy in the Tackle CR and inserts it into the Getting Started assembly; expands Developer Lightspeed docs with explicit Solution Server, Agent mode, and LLM proxy workflows; updates introductory context guidance and Podman Desktop provider example. Changes
Sequence Diagram(s)mermaid Admin->>CLI: oc login / oc edit tackle_hub.yaml Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Around line 14-15: The sentence "You can complete one of the following
workflow depending on if you want to use the Solution Server or the Agent AI."
is awkward; update it in the document to read "You can complete one of the
following workflows depending on whether you want to use the Solution Server or
Agent AI." — change "workflow" to "workflows" and "depending on if" to
"depending on whether" in the paragraph containing that sentence.
In `@docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc`:
- Line 54: Update the sentence "The Solution Server acts as an institutional
memory that stores changes to source codes after analyzing applications in your
organization." by replacing the phrase "source codes" with "source code" so it
reads "stores changes to source code"; locate this exact sentence in the
document (the sentence beginning "The Solution Server acts as an institutional
memory...") and make the single-word plural-to-collective change.
- Around line 64-65: The bullet "Works with the LLM to generate fix suggestions.
The LLM displays the reasoning transcript and files to be changed." is missing a
list marker; update the document so that this line begins with the same list
marker as the surrounding items (add a leading "*" and match indentation) so it
renders as a list item in the agentic workflow list.
In `@docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc`:
- Around line 26-53: The procedure mixes live-edit and file-based flows (uses
"oc edit tackle" but later runs "oc apply -f tackle_hub.yaml" and references
both tackle_hub.yml and tackle_hub.yaml) — choose one flow and make filenames
consistent: either keep the live-edit flow (use "oc edit tackle mta" in
namespace openshift-mta and remove the "oc apply" step and any mention of
tackle_hub.yaml), or convert to a file-based flow by exporting the resource with
"oc get tackle mta -o yaml > tackle_hub.yaml", edit the exported tackle_hub.yaml
to set spec.kai_llm_proxy_enabled: true (ensure key is exactly
kai_llm_proxy_enabled), and then apply with "oc apply -f tackle_hub.yaml"; also
normalize the filename to tackle_hub.yaml everywhere.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/topics/developer-lightspeed/assembly_getting-started.adocdocs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adocdocs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adocdocs/topics/developer-lightspeed/proc_configuring-llm-podman-desktop.adocdocs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc (1)
41-47:⚠️ Potential issue | 🟡 MinorTighten grammar for subject-verb agreement in the context section.
On Line 41 and Line 47, singular verbs are used with plural subjects, which hurts readability.
Suggested fix
-More instances of solved examples for an issue enhances the context and improve the success metrics of rules that trigger the issue. A higher success metrics of an issue refers to the higher confidence level associated with the accepted resolutions for that issue in previous analyses. +More instances of solved examples for an issue enhance the context and improve the success metrics of rules that trigger the issue. Higher success metrics for an issue refer to a higher confidence level associated with the accepted resolutions for that issue in previous analyses. ... -This cyclical improvement of resolution pattern from the Solution Server and improved migration hints lead to more reliable code changes as you migrate applications in different migration waves. +This cyclical improvement of resolution patterns from the Solution Server and improved migration hints leads to more reliable code changes as you migrate applications in different migration waves.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc` around lines 41 - 47, Fix subject-verb agreement in the added sentences: change "This cyclical improvement of resolution pattern from the Solution Server and improved migration hints lead to more reliable code changes..." to use the singular verb ("leads") so it reads "...leads to more reliable code changes," and verify any other occurrences in the nearby sentences (e.g., the sentence beginning "The improvement in the quality of migration hints..." and the sentence starting "Accurate code resolutions from the LLM...") maintain correct singular/plural agreement.
♻️ Duplicate comments (3)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc (1)
14-14:⚠️ Potential issue | 🟡 MinorFix awkward grammar in workflow selection sentence.
The phrase "one of the following workflows depending on if" is grammatically awkward. Change "depending on if" to "depending on whether."
✏️ Proposed fix
-The configuration that you complete to use {mta-dl-plugin} depends on how you prefer to request code resolutions. You can complete one of the following workflows depending on if you want to use the Solution Server or the Agent AI. +The configuration that you complete to use {mta-dl-plugin} depends on how you prefer to request code resolutions. You can complete one of the following workflows depending on whether you want to use the Solution Server or Agent AI.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc` at line 14, Replace the awkward phrase in the sentence that begins "The configuration that you complete to use {mta-dl-plugin}..." — specifically change "one of the following workflows depending on if you want to use the Solution Server or the Agent AI." to use "depending on whether" (i.e., "one of the following workflows depending on whether you want to use the Solution Server or the Agent AI.") so the sentence reads grammatically correct.docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc (2)
26-31:⚠️ Potential issue | 🔴 CriticalCritical: Procedure contains incorrect command that doesn't match the described workflow.
Line 26 states "Create the Tackle CR in the
tackle_hub.yamlfile" but line 30 showsvi tackle(without the.yamlextension). This mismatch makes the procedure impossible to follow correctly, as users will edit a file namedtacklebut later try to applytackle_hub.yaml(line 54).Additionally, the procedure doesn't explain how to obtain the existing Tackle CR before editing. You need to export it first.
📝 Recommended fix: Use consistent file-based workflow
-. Create the Tackle CR in the `tackle_hub.yaml` file with the following command: +. Export the existing Tackle CR to a local file: + [source, terminal] ---- -vi tackle +oc get tackle mta -n openshift-mta -o yaml > tackle_hub.yaml ---- ++ +. Edit the exported `tackle_hub.yaml` file: ++ +[source, terminal] +---- +vi tackle_hub.yaml +----🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc` around lines 26 - 31, The procedure is inconsistent: it references creating/editing the Tackle CR in "tackle_hub.yaml" but shows the edit command "vi tackle" and omits exporting the existing CR; update the steps to consistently use the same filename (tackle_hub.yaml) and add the export command to fetch the existing Tackle CR before editing (e.g., use kubectl get <TackleCRKind> <name> -o yaml > tackle_hub.yaml), then edit tackle_hub.yaml with your editor (replace "vi tackle" with "vi tackle_hub.yaml") and ensure subsequent steps (like apply) reference tackle_hub.yaml and not a different filename so Tackle CR export, edit (tackle_hub.yaml), and apply are consistent.
50-50:⚠️ Potential issue | 🟡 MinorFix grammatical error.
"Apply the Tackle CR by in the
openshift-mtaproject" contains a grammatical error with "by in."✏️ Proposed fix
-. Apply the Tackle CR by in the `openshift-mta` project using the following command. +. Apply the updated Tackle CR in the `openshift-mta` project using the following command:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc` at line 50, The sentence "Apply the Tackle CR by in the `openshift-mta` project using the following command." has an extra "by"; remove it and change the sentence to "Apply the Tackle CR in the `openshift-mta` project using the following command." so the line in docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc reads correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Line 12: The xref target "tackle-enable-llm-proxy_getting-started" in
con_developer-lightspeed-pathways.adoc is resolving incorrectly because the
assembly inclusion doesn't set the context to "getting-started"; either change
the xref to the actual resolved ID "tackle-enable-llm-proxy_" or ensure the
include/assembly sets the context variable to "getting-started" when pulling in
assembly_getting-started.adoc (or update master.adoc to provide the parent
context), so update the xref target or the assembly context accordingly to match
the real ID.
In `@docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc`:
- Line 63: The attribute token {nta-dl-plugin} on the sentence mentioning the
sub agent is likely a typo and should match the rest of the file; replace
{nta-dl-plugin} with the correct attribute {mta-dl-plugin} so the reference
resolves consistently (search for occurrences of {mta-dl-plugin} and update the
instance in the sentence "Chooses a suitable sub agent..." to use that same
attribute).
---
Outside diff comments:
In `@docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc`:
- Around line 41-47: Fix subject-verb agreement in the added sentences: change
"This cyclical improvement of resolution pattern from the Solution Server and
improved migration hints lead to more reliable code changes..." to use the
singular verb ("leads") so it reads "...leads to more reliable code changes,"
and verify any other occurrences in the nearby sentences (e.g., the sentence
beginning "The improvement in the quality of migration hints..." and the
sentence starting "Accurate code resolutions from the LLM...") maintain correct
singular/plural agreement.
---
Duplicate comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Line 14: Replace the awkward phrase in the sentence that begins "The
configuration that you complete to use {mta-dl-plugin}..." — specifically change
"one of the following workflows depending on if you want to use the Solution
Server or the Agent AI." to use "depending on whether" (i.e., "one of the
following workflows depending on whether you want to use the Solution Server or
the Agent AI.") so the sentence reads grammatically correct.
In `@docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc`:
- Around line 26-31: The procedure is inconsistent: it references
creating/editing the Tackle CR in "tackle_hub.yaml" but shows the edit command
"vi tackle" and omits exporting the existing CR; update the steps to
consistently use the same filename (tackle_hub.yaml) and add the export command
to fetch the existing Tackle CR before editing (e.g., use kubectl get
<TackleCRKind> <name> -o yaml > tackle_hub.yaml), then edit tackle_hub.yaml with
your editor (replace "vi tackle" with "vi tackle_hub.yaml") and ensure
subsequent steps (like apply) reference tackle_hub.yaml and not a different
filename so Tackle CR export, edit (tackle_hub.yaml), and apply are consistent.
- Line 50: The sentence "Apply the Tackle CR by in the `openshift-mta` project
using the following command." has an extra "by"; remove it and change the
sentence to "Apply the Tackle CR in the `openshift-mta` project using the
following command." so the line in
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc reads
correctly.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adocdocs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adocdocs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_configuring-llm-podman-desktop.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Line 29: The doc uses inconsistent casing for the product name: replace the
lowercase occurrences of "solution server" with the proper capitalized term
"Solution Server" (specifically the instances shown in the diff where "solution
server" appears) to match the rest of the document; search for the literal
string "solution server" in con_developer-lightspeed-pathways.adoc and update
each to "Solution Server" so all references are consistent.
In `@docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc`:
- Around line 63-64: The sentence "The LLM displays the reasoning transcript and
files to be changed" is misleading; update the text to attribute display
responsibilities to the extension/agent UI rather than the model. Edit the
bullet containing "{mta-dl-plugin}" and the line with "The LLM displays the
reasoning transcript and files to be changed" to say that the agent/extension
(or {mta-dl-plugin}) presents the reasoning transcript and proposed file changes
in the UI while the LLM generates suggestions, ensuring the distinction between
the model (LLM) and the UI/agent is clear.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 89958ccd-98ba-4911-8952-c51056301b72
📒 Files selected for processing (5)
docs/topics/developer-lightspeed/assembly_getting-started.adocdocs/topics/developer-lightspeed/assembly_solution-server-configurations.adocdocs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adocdocs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adocdocs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
💤 Files with no reviewable changes (1)
- docs/topics/developer-lightspeed/assembly_solution-server-configurations.adoc
🚧 Files skipped from review as they are similar to previous changes (2)
- docs/topics/developer-lightspeed/assembly_getting-started.adoc
- docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_intro-to-developer-lightspeed.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc (1)
27-29:⚠️ Potential issue | 🟡 MinorUse consistent product-term capitalization for “Solution Server.”
Line 27, Line 29, and Line 67 still use lowercase “solution server,” while the rest of the page uses “Solution Server.” Please standardize all occurrences to the same casing.
Suggested doc fix
-== Workflow to use the solution server +== Workflow to use the Solution Server -Solution server is an optional component. As a migrator, complete the following workflow to use the Solution Server for code resolutions: +The Solution Server is an optional component. As a migrator, complete the following workflow to use the Solution Server for code resolutions: -NOTE: If you want to use the Solution Server, you must also enable solution server in the Tackle CR. +NOTE: If you want to use the Solution Server, you must also enable the Solution Server in the Tackle CR.Also applies to: 67-67
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc` around lines 27 - 29, The document uses inconsistent casing for the product term “Solution Server” (e.g., the header text "Workflow to use the solution server" and occurrences of the phrase "solution server" at/around the lines noted); update all occurrences of the lowercase phrase "solution server" to the standardized "Solution Server" throughout the document (including the header and the instances called out around lines 27, 29, and 67) so the term is capitalized consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Around line 27-29: The document uses inconsistent casing for the product term
“Solution Server” (e.g., the header text "Workflow to use the solution server"
and occurrences of the phrase "solution server" at/around the lines noted);
update all occurrences of the lowercase phrase "solution server" to the
standardized "Solution Server" throughout the document (including the header and
the instances called out around lines 27, 29, and 67) so the term is capitalized
consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: acd0158d-affe-4f7e-b51c-920f53e2b4c6
📒 Files selected for processing (2)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adocdocs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/topics/developer-lightspeed/proc_tackle-enable-llm-proxy.adoc
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc (1)
27-29:⚠️ Potential issue | 🟡 MinorKeep “Solution Server” capitalization consistent.
Line 27/29 and Line 67 still mix casing (“solution server” vs “Solution Server”). Please standardize on Solution Server throughout this module.
Also applies to: 67-67
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc` around lines 27 - 29, The document mixes casing for the term "Solution Server"; standardize all occurrences to "Solution Server" (capital S on both words). Locate uses of "solution server" and replace them with "Solution Server" in this file, including the heading "Workflow to use the solution server" and the instance around line 67, and scan the rest of con_developer-lightspeed-pathways.adoc to ensure every mention of the component uses the exact "Solution Server" capitalization consistently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Line 22: The document uses inconsistent terminology: "Agent AI" on line with
the phrase “Whether you want to use Retrieval Augmented Generation (RAG) or
Agent AI” and "agent mode" in the later block (lines 44–47). Pick one canonical
term (e.g., "Agent mode" or "Agent AI") and replace all occurrences so they
match across the file—update the phrase in the RAG/Agent line and the
description in the block that currently reads "agent mode" to the chosen term so
the wording is consistent.
- Line 57: The sentence starting "The LLM proxy service authenticates the
{ProductShortName} Visual Studio Code extension (clients) by using the Hub
credentials..." is long and contains an extra space before "for more
information."; split it into two sentences for clarity (one describing how the
LLM proxy authenticates clients and a second describing the proxy's separate
authentication to access the LLM via an admin-controlled endpoint) and remove
the stray space before the xref:tackle-enable-llm-proxy_getting-started[Enabling
LLM proxy in the Tackle custom resource] reference so the final text reads as
two concise sentences with correct spacing.
---
Duplicate comments:
In `@docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc`:
- Around line 27-29: The document mixes casing for the term "Solution Server";
standardize all occurrences to "Solution Server" (capital S on both words).
Locate uses of "solution server" and replace them with "Solution Server" in this
file, including the heading "Workflow to use the solution server" and the
instance around line 67, and scan the rest of
con_developer-lightspeed-pathways.adoc to ensure every mention of the component
uses the exact "Solution Server" capitalization consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4d1899ed-3a9a-4d0a-a0e7-19984943fc12
📒 Files selected for processing (1)
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
docs/topics/developer-lightspeed/con_developer-lightspeed-pathways.adoc
Outdated
Show resolved
Hide resolved
|
@fabianvf Could you review the documentation for LLM proxy, please? |
Pkylas007
force-pushed
the
mta-6288-llm-proxy
branch
from
22d7ccf to
fd70c4a
Compare
|
|
||
| * Enable the generative AI option in the {ProductShortName} extension settings. | ||
|
|
||
| * Add the Solution Server configuration in the `settings.json` file. |
There was a problem hiding this comment.
The solution server configuration is now automatically discovered upon connection to the hub, no manual entry is required
There was a problem hiding this comment.
So you configure connection to the hub via the panel in the analysis page. You additionally enable the solution server (or configuration sync) as feature toggles on the same panel.
There was a problem hiding this comment.
Hi @fabianvf @djzager Thank you! My bad, this is a workflow to use Solution Server when the users do not want to connect with the Hub. I'll update the title to add that detail. If this workflow is possible, will the users be able to enter the Solution Server config in settings.json as they used to in 8.0.0?
There was a problem hiding this comment.
You must configure the hub in order to enable the solution server. It can no longer be configured solo in the settings.json.
A little context, you were always connecting to the hub when using the solution server. We pulled it into the hub configuration because the profile sync is using the same coordinates.
| + | ||
| [NOTE] | ||
| ==== | ||
| As a migrator, you can configure Solution Server and LLM provider settings in the {ProductShortName} Visual Studio Code extension only when LLM proxy is not enabled in the {ocp-name} cluster. |
There was a problem hiding this comment.
@djzager is this true? I think solution server configuration is always pulled from the hub now, and I think the setting to use it is changeable whether or not the llm-proxy is deployed.
There was a problem hiding this comment.
solution server is it's own feature flag in the settings screen. Will see if I can get a screenshot when I get back online tonight.
There was a problem hiding this comment.
Hi @djzager Can you please confirm if the users do not connect the VS Code extension with the Hub, then they can still configure Solution Server in settings.json as they used in 8.0.0?
There was a problem hiding this comment.
Yes, if the solution server is deployed in the cluster, you can connect to it by configuring the hub connection. Neither LLM proxy nor solution server are accessible without configuring the hub connection
There was a problem hiding this comment.
I have added details about deploying the proxy, SS, and connecting to the Hub to use the Solution Server. Could you go through the updates, please?
| To use the agent mode for code fix suggestions: | ||
| As a migrator, complete the following workflow to use the agent mode for code resolutions: | ||
|
|
||
| * Create a secret for your LLM key in the Red Hat {ocp-name} cluster. |
There was a problem hiding this comment.
This is something only administrators should need/will be able to do, and the agentic workflow will work with or without the hub connection enabled.
There was a problem hiding this comment.
Mentioned this as a task that the admin completes, thanks!
| * Enable the generative AI and the agent mode in the {ProductShortName} extension settings. | ||
|
|
||
| * Configure the profile settings and activate the LLM provider in the `provider-settings.yaml` file. No newline at end of file | ||
| * Configure the profile settings and activate the LLM provider in the `provider-settings.yaml` file. |
There was a problem hiding this comment.
If they enable the hub connection, they will also be able to use agent mode through the llm-proxy when available
There was a problem hiding this comment.
So either they'd need to configure their local settings, or they'd need to connect to a hub with a running llm-proxy
There was a problem hiding this comment.
I've corrected the pathway section..Please could you take a look at it again?
fabianvf
left a comment
fabianvf
left a comment
There was a problem hiding this comment.
Couple comments but everything else looked good
| [id="solution-server-workflow_{context}"] | ||
| == Workflow to use the solution server without the LLM proxy | ||
|
|
||
| As an administrator, you must complete the following workflow to enable migrators to use the Solution Server in the {ProductShortName} extension: |
There was a problem hiding this comment.
see previous PRs, use capitalization for role titles consistently
There was a problem hiding this comment.
Got it, fixed it in the current assembly :)
|
|
||
| * You deployed an additional RWO volume for the `{mta-dl-plugin}-database` if you want to use {mta-dl-plugin}. See link:{mta-URL}/installing_the_migration_toolkit_for_applications/index#persistent-volume-requirements_installing-mta-ui[Persistent volume requirements] for more information. | ||
|
|
||
| * You installed the {ProductShortName} Operator v8.0.0. |
There was a problem hiding this comment.
please check which version of the operator as 8.0.0 seems a bit weird
There was a problem hiding this comment.
Aw...yes, fixed it 👍, thanks!
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
Pkylas007
force-pushed
the
mta-6288-llm-proxy
branch
from
8c3df4b to
05d16f8
Compare
Signed-off-by: Prabha Kylasamiyer Sundara Rajan <pkylasam@pkylasam-thinkpadp16vgen1.bengluru.csb>
5 participants
JIRA
Version
Preview
What Changed
Restructured the following section to introduce sub section for readability:
Summary by CodeRabbit