Support file system synchronized group membership exceptions#89
Merged
mikeger merged 4 commits intoJun 9, 2026
Merged
Conversation
Owner
|
Thanks for the contribution @Econa77 ! Can you check if the folders exclusion works as expected? I suspect it might not be the case. @Test
func projectDeepFolderMembershipExceptionFolderChange() async throws {
// given
let testTool = try IntegrationTestTool()
defer { try? testTool.tearDown() }
let tool = try testTool.createSUT(config: nil,
basePath: "ExampleProject.xcodeproj")
// when
try testTool.changeFile(at: testTool.projectPath + "ExampleProject/DeepFolder/Path/ExcludedFolder/ExcludedFolderView.swift")
// then
let result = try await tool.run()
#expect(result == Set<TargetIdentity>())
}where the fixture has ExcludedFolder as excluded. If you prefer, I can do the change to support folders. |
Contributor
Author
|
@mikeger Thanks, you were right. The previous logic only handled exact path matches, so folder membership exceptions did not exclude files under that folder. I updated it to exclude both the exception path itself and descendants of that path 👍 |
mikeger
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on #48.
Summary
PBXFileSystemSynchronizedBuildFileExceptionSet.membershipExceptionsfileSystemSynchronizedGroupsFilesto recursive file pathsNotes
The previous synchronized group support used
recursiveChildren()and treated the returned paths as target inputs. SincerecursiveChildren()also returns directories, those directories could be registered as folder dependencies. That was not intended: synchronized group handling here should track files, not make every intermediate folder affect the target.