Optimize tokio Runtime usage in benchmarks#15
Open
ixand wants to merge 6 commits into
Open
Conversation
CodSpeed Performance ReportMerging #15 will not alter performanceComparing Summary
Benchmarks breakdown
|
Owner
|
Thanks for the contribution! 🙏 |
Author
|
I am glad to contribute! So in the last commit I did what you asked me
before and changed my approach to deal with it. I hope it will be useful!
…On Tue, Jul 29, 2025 at 2:48 PM Mikko Leppänen ***@***.***> wrote:
*mikeleppane* left a comment (mikeleppane/visualvault#15)
<#15 (comment)>
Thanks for the contribution! 🙏
Please run cargo format and cargo clippy. You can use just format and just
clippy for these. Make sure you have just installed:
https://just.systems/man/en/packages.html
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHUXZXPORRK57TZ3AOUZQEL3K5NPFAVCNFSM6AAAAACCS6MRLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMZSGEYDKMBSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the usage of
tokio::Runtimein benchmark files by instantiating it only once and passing it into benchmark functions, instead of creating it for every test case.Why
Let me know if you'd prefer a different structure!