fix: correct CFN template path in S3 publish step#77
Merged
Conversation
The CloudFormation template moved into an infrastructure/aws/cloudformation/ subdirectory (via upstream sync from pl), but the publish workflow still uploaded from infrastructure/aws/cloudformation-eks-1-35.yaml. That path no longer exists, so 'aws s3 cp' failed on the last two release tags and the public S3 object (cloudformation-eks-1-35.yaml) froze at an old version (3.5.0, no metrics-server). Fix the path and add guards so the step fails loudly instead of silently serving a stale template: - error if the template file is missing - error if the template's Platforma version != chart version being released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The public CloudFormation install template at
https://platforma-cloudformation.s3.eu-central-1.amazonaws.com/cloudformation-eks-1-35.yamlwas stale (stuck at Platforma3.5.0, missing themetrics-serveraddon) whileplmain was at4.0.1.Root cause: the template moved into an
infrastructure/aws/cloudformation/subdirectory (via upstream sync frompl), but theUpload CFN template to S3step still copied from./infrastructure/aws/cloudformation-eks-1-35.yaml— a path that no longer exists.aws s3 cptherefore failed on the last two release tags ("Publish Helm Chart" runs 27200663170, 26902329525 went red), so the S3 object kept the last successful upload from 2026-05-12.Impact: stacks upgrading against the public URL saw a plan to delete metrics-server and downgrade Platforma 4.0.1 → 3.5.0.
Fix
./infrastructure/aws/cloudformation/cloudformation-eks-1-35.yaml.Platformaversion != the chart version being released--content-type text/yamlon upload.Note
The live S3 object was already manually refreshed to
4.0.1(md5-verified againstplmain) as a stopgap, with the previous 3.5.0 template backed up tos3://platforma-cloudformation/cloudformation-eks-1-35.yaml.bak-3.5.0-20260512. This PR makes the next release republish correctly on its own.