fix(cli): replace pre-existing expect skill folders with symlinks#73
Draft
fix(cli): replace pre-existing expect skill folders with symlinks#73
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Contributor
Test Results❌ Website Test: failedSession Recordinghttps://github.com/millionco/expect/releases/download/ci-pr-73/f47f6b8c27d373244c18dcc319f2aa31.webm |
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureAgentSymlinkto replace existing non-symlinkexpectpaths (including directories/files created byskills.sh) with the expected symlinkContext
This fixes installation failures like:
.codex/skills/expect exists and is not a symlink.cursor/skills/expect exists and is not a symlink.opencode/skills/expect exists and is not a symlinkwhen users have an existing
expectfolder fromskills.sh.Validation
pnpm test add-skill(inapps/cli)pnpm typecheckfails due to pre-existing issues inpackages/browser(missing generated runtime files and unrelated typing errors)pnpm testfails due to environment-dependent cookie tests inpackages/cookiespnpm buildsucceedsSlack Thread
Summary by cubic
Replace any pre-existing non-symlink or broken
expectskill path with the correct symlink during CLI install. Keeps valid symlinks; replaces mismatched, broken, or directory/file paths with../../.agents/skills/expect..codex/skills/expect,.cursor/skills/expect, or.opencode/skills/expectalready exist as a folder/file or as a broken/mismatched symlink by removing them and linking to../../.agents/skills/expect.Written for commit c903e1c. Summary will update on new commits.