More model providers, more fun.#752
Open
hnrie wants to merge 1 commit into
Open
Conversation
Contributor
|
I'm not sure if this is necessary. I'll let @MaxRobinsonTheGreat decide. |
Author
alr sure |
Contributor
|
Maybe in #766 we could find a way to do this without having to create a new provider with boilerplate code for each OpenAI-compatible provider. |
Ninot1Quyi
added a commit
that referenced
this pull request
May 1, 2026
Merge PR 752 first so its original provider-addition commit remains visible before the branch adapts those providers into the shared registry style. Constraint: Preserve visible PR merge history for PR 752 Confidence: high Scope-risk: moderate Related: #752 Tested: PR provider files merged before registry adaptation Not-tested: Live provider calls at merge point Co-authored-by: OmX <omx@oh-my-codex.dev>
Ninot1Quyi
added a commit
that referenced
this pull request
May 1, 2026
The PR added eight OpenAI-compatible providers as separate model classes. This branch now keeps that contribution as provider registry entries so the shared OpenAI completions transport handles them without reintroducing boilerplate adapters. Constraint: New provider support should use llm_providers registry records rather than one class per OpenAI-compatible endpoint Rejected: Keep the PR 752 class files | they duplicate the shared OpenAI-compatible transport and weaken the new configuration style Confidence: high Scope-risk: moderate Related: #752 Tested: npm test passed 50/50; JSON parse check for llm_providers example/local config; git diff --cached --check Not-tested: Live calls to the eight added providers Co-authored-by: OmX <omx@oh-my-codex.dev>
Contributor
|
This PR has been merged into #769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More model providers, more fun.