Convert core streamdaq routines to noob#192
Draft
sneakers-the-rat wants to merge 3 commits into
Draft
Conversation
Comment on lines
+50
to
+51
| while True: | ||
| yield next(dev) |
Collaborator
Author
There was a problem hiding this comment.
i'm pretty sure this can just be yield from dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting the core of the streamdaq to noob, opening as a draft, this might take a day or two since we need to also add an additional feature to noob to ensure all the queues get drained when we hit 'stop'.
probably going to do this in two stages, first the core frame construction stuff, and then handle the video/csv writer/plotting stuff in a second PR
📚 Documentation preview 📚: https://miniscope-io--192.org.readthedocs.build/en/192/