Use selenium 2 as the default version#410
Merged
aik099 merged 2 commits intominkphp:masterfrom Jan 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
=========================================
Coverage 86.21% 86.21%
Complexity 185 185
=========================================
Files 1 1
Lines 515 515
=========================================
Hits 444 444
Misses 71 71 ☔ View full report in Codecov by Sentry. |
aik099
approved these changes
Jan 19, 2025
Member
|
@uuf6429 , inform me once PR is ready (I hope any PR's in non-Draft status are ready for review). |
Member
Author
|
@aik099 It's ready now. |
Member
|
Merged. Thanks @uuf6429 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed this in the original PR. This driver cannot work with Selenium 4 at all, so it makes sense to use a supported default version, if for anything to avoid confusing users.