Conversation
Contributor
OBorce
commented
Feb 13, 2026
OBorce
commented
- only send wallet events when tx has actually changed state
- when checking balance in functional tests check in-mempool states as well
OBorce
force-pushed
the
fix/wallet-mempool-tests
branch
3 times, most recently
from
72b3097 to
853ace0
Compare
- only send wallet events when tx has actually changed state - when checking balance in functional tests check in-mempool states as well
OBorce
force-pushed
the
fix/wallet-mempool-tests
branch
from
853ace0 to
8c5fd4a
Compare
ImplOfAnImpl
approved these changes
Feb 17, 2026
| #[rstest] | ||
| #[trace] | ||
| #[case(test_utils::random::Seed::from_entropy())] | ||
| #[case(test_utils::random::Seed::from(8923949037148047608))] |
| )); | ||
| assert_eq!(evt4.tx_id(), evt1.tx_id()); | ||
| let events = | ||
| collect_until_confirmed(&mut wallet_events, evt1.tx_id(), Duration::from_millis(500)) |
Contributor
There was a problem hiding this comment.
IMO the timeout should be noticeably bigger, e.g. 10s, otherwise the test may spuriously fail on a slow machine when tests are run in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.