Skip to content

add read.md#1

Open
aditreza wants to merge 13 commits into
miracle-fox-2017:masterfrom
aditreza:master
Open

add read.md#1
aditreza wants to merge 13 commits into
miracle-fox-2017:masterfrom
aditreza:master

Conversation

@aditreza
Copy link
Copy Markdown

No description provided.

@tamatamvan
Copy link
Copy Markdown

overall oke, cuma ada beberapa feedback. saat catch error sebenernya ga perlu di if (err) lgi, karna udah pasti ada error kalau masuk ke catch.
terus coba perhatikan code dibawah:

/*
Dua routing di bawah ini berarti yg punya data user itu kalau bukan admin 
dia ga bisa ngakses routing itu don?
Routing di bawah cuma bisa diakses sama yang punya data nya, 
dan juga kalau yg punya itu adalah admin aja.
*/
 router.get('/users/:id', verify.isLogin, verify.isAdmin, verify.isAuthById, User.getUserById)
 router.put('/users/:id', verify.isLogin, verify.isAdmin, verify.isAuthById, User.updateUsers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants