Skip to content

labs: graduate admin API to GA, remove adminapi flag#832

Merged
evanphx merged 1 commit into
mainfrom
mir-1175-ga-remove-adminapi-flag
Jun 9, 2026
Merged

labs: graduate admin API to GA, remove adminapi flag#832
evanphx merged 1 commit into
mainfrom
mir-1175-ga-remove-adminapi-flag

Conversation

@evanphx

@evanphx evanphx commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Graduates the Admin API from a Miren Labs feature to GA by removing the adminapi flag and making the admin API always-on.

The adminapi flag only gated two things; the admin token is already generated unconditionally for every app version (servers/build/build.go), and the miren admin CLI was never flag-gated — so GA-ing the feature is just dropping the two guards plus cleanup.

Changes

  • pkg/labs/features.yaml — remove the adminapi feature; regenerate pkg/labs/labs.gen.go (drops FeatureAdminAPI and the AdminAPI() predicate).
  • components/coordinate/coordinate.go — always expose the admin RPC server (removed if labs.AdminAPI()).
  • controllers/deployment/launcher.go — inject ADMIN_TOKEN whenever a version has a token; removed the now-unused labs import.
  • pkg/labs/labs_test.go — swap the two adminapi test references for distributedrunners.
  • cli/commands/server_install_docker.go + regenerated docs/docs/command/server-docker-install.md--labs help example no longer references adminapi.
  • docs/docs/labs.md — replace adminapi examples.

Compatibility

Existing deployments passing --labs adminapi will log a "unknown labs feature flag" warning but otherwise work fine — the admin API is now always on. No compat shim added; the warning serves as a soft deprecation signal.

Testing

  • go test ./pkg/labs/... — pass
  • go vet across coordinate / deployment / admin / cli — clean
  • make lint — 0 issues, docs lint passed
  • Full host binary build — compiles

Closes MIR-1175

@evanphx evanphx requested a review from a team as a code owner May 28, 2026 23:07
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60abf37b-73cc-49e7-91ab-1f427821f389

📥 Commits

Reviewing files that changed from the base of the PR and between 5244553 and feb66e4.

📒 Files selected for processing (8)
  • cli/commands/server_install_docker.go
  • components/coordinate/coordinate.go
  • controllers/deployment/launcher.go
  • docs/docs/command/server-docker-install.md
  • docs/docs/labs.md
  • pkg/labs/features.yaml
  • pkg/labs/labs.gen.go
  • pkg/labs/labs_test.go
💤 Files with no reviewable changes (2)
  • pkg/labs/labs.gen.go
  • pkg/labs/features.yaml
✅ Files skipped from review due to trivial changes (3)
  • docs/docs/command/server-docker-install.md
  • cli/commands/server_install_docker.go
  • docs/docs/labs.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • components/coordinate/coordinate.go
  • controllers/deployment/launcher.go

📝 Walkthrough

Walkthrough

This PR removes the adminapi feature flag from the Miren Labs system and makes the admin RPC endpoint unconditionally available. The coordinator now always exposes the admin endpoint regardless of lab settings. The deployment launcher no longer gates ADMIN_TOKEN injection on the admin API lab flag. Documentation examples and CLI help text are updated to reference distributedrunners instead of the removed adminapi feature, and tests are adjusted to match the new feature set.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@phinze phinze left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to ship when you're ready! 🚢

The admin interface is now generally available. Remove the `adminapi`
Miren Labs feature flag and make the admin API always-on:

- Drop the `adminapi` feature from pkg/labs/features.yaml and regenerate
  labs.gen.go (removes FeatureAdminAPI and the AdminAPI() predicate).
- Always expose the admin RPC server in coordinate.go.
- Inject ADMIN_TOKEN whenever a version has a token (launcher.go); the
  token is already generated unconditionally per app version.
- Update labs tests and the --labs help example to reference a remaining
  labs feature, and regenerate command docs.
- Update docs/labs.md examples.
@evanphx evanphx force-pushed the mir-1175-ga-remove-adminapi-flag branch from 5244553 to feb66e4 Compare June 9, 2026 21:43
@evanphx evanphx enabled auto-merge June 9, 2026 21:44
@evanphx evanphx merged commit 63b5dec into main Jun 9, 2026
19 checks passed
@evanphx evanphx deleted the mir-1175-ga-remove-adminapi-flag branch June 9, 2026 21:54
@miren-code-agent miren-code-agent Bot mentioned this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants