labs: graduate admin API to GA, remove adminapi flag#832
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR removes the Comment |
|
Actionable comments posted: 0 |
phinze
left a comment
There was a problem hiding this comment.
Ready to ship when you're ready! 🚢
The admin interface is now generally available. Remove the `adminapi` Miren Labs feature flag and make the admin API always-on: - Drop the `adminapi` feature from pkg/labs/features.yaml and regenerate labs.gen.go (removes FeatureAdminAPI and the AdminAPI() predicate). - Always expose the admin RPC server in coordinate.go. - Inject ADMIN_TOKEN whenever a version has a token (launcher.go); the token is already generated unconditionally per app version. - Update labs tests and the --labs help example to reference a remaining labs feature, and regenerate command docs. - Update docs/labs.md examples.
5244553 to
feb66e4
Compare
Summary
Graduates the Admin API from a Miren Labs feature to GA by removing the
adminapiflag and making the admin API always-on.The
adminapiflag only gated two things; the admin token is already generated unconditionally for every app version (servers/build/build.go), and themiren adminCLI was never flag-gated — so GA-ing the feature is just dropping the two guards plus cleanup.Changes
pkg/labs/features.yaml— remove theadminapifeature; regeneratepkg/labs/labs.gen.go(dropsFeatureAdminAPIand theAdminAPI()predicate).components/coordinate/coordinate.go— always expose the admin RPC server (removedif labs.AdminAPI()).controllers/deployment/launcher.go— injectADMIN_TOKENwhenever a version has a token; removed the now-unusedlabsimport.pkg/labs/labs_test.go— swap the twoadminapitest references fordistributedrunners.cli/commands/server_install_docker.go+ regenerateddocs/docs/command/server-docker-install.md—--labshelp example no longer referencesadminapi.docs/docs/labs.md— replaceadminapiexamples.Compatibility
Existing deployments passing
--labs adminapiwill log a"unknown labs feature flag"warning but otherwise work fine — the admin API is now always on. No compat shim added; the warning serves as a soft deprecation signal.Testing
go test ./pkg/labs/...— passgo vetacross coordinate / deployment / admin / cli — cleanmake lint— 0 issues, docs lint passedCloses MIR-1175