-
Notifications
You must be signed in to change notification settings - Fork 4
Release v0.10.0 #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+198
−25
Merged
Release v0.10.0 #853
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c9d6f6
Update changelog for v0.10.0
evanphx 34df0ec
Release v0.10.0
evanphx 568fbee
Use concrete example values in logs -f changelog entry
evanphx cda86c3
sandbox: re-register workload-identity token secrets on controller re…
evanphx cff68b8
sandbox: harden loadTokenSecret against trailing newlines
evanphx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the best-effort file delete even when
tokenSecretsis nil.WorkloadIssueris optional on this controller, so it can still be cleaning up old sandboxes that already have persistedtoken-secretfiles whilec.tokenSecretsis nil. In that configuration this branch is skipped, and any earlyStopSandboxfailure leaves the secret on disk—the cleanup hole this change is meant to close.Suggested fix
if c.tokenSecrets != nil { c.tokenSecrets.unregister(id.String()) - // Best-effort removal of the persisted secret. StopSandbox also wipes the whole - // sandbox dir, but removing the sensitive secret here ensures it doesn't linger - // if StopSandbox errors out before reaching its dir cleanup. - secretPath := filepath.Join(c.Tempdir, "containerd", id.PathSafe(), tokenSecretFilename) - if err := os.Remove(secretPath); err != nil && !os.IsNotExist(err) { - c.Log.Warn("failed to remove persisted token secret", "sandbox", id, "error", err) - } } + // Best-effort removal of the persisted secret. StopSandbox also wipes the whole + // sandbox dir, but removing the sensitive secret here ensures it doesn't linger + // if StopSandbox errors out before reaching its dir cleanup. + secretPath := filepath.Join(c.Tempdir, "containerd", id.PathSafe(), tokenSecretFilename) + if err := os.Remove(secretPath); err != nil && !os.IsNotExist(err) { + c.Log.Warn("failed to remove persisted token secret", "sandbox", id, "error", err) + }🤖 Prompt for AI Agents