Add timeout to raw_bg read, avoid hang on certain platforms#2
Open
mitchcapper wants to merge 1 commit intomisaki-web:mainfrom
Open
Add timeout to raw_bg read, avoid hang on certain platforms#2mitchcapper wants to merge 1 commit intomisaki-web:mainfrom
mitchcapper wants to merge 1 commit intomisaki-web:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First you are a crazy mad person with far too much love for bash;)
Second, this script works on linux (ubuntu) and windows (msys but native windows highlight.exe) but I ran into an issue.
grepp/grep+
Line 1001 in cfc8148
this command that looks like its trying to read the background color from the terminal hangs on both platforms for me.
As I am not nearly as smart as you however, I can't figure out exactly how it should work to actually fix it. Instead here is a quick 1 second timeout to prevent the hang for those of us who don't have the slash incoming.