fix: listener leak, archive path, vault index cache, edge cases#2
Merged
Conversation
Owner
mishachepi
commented
Apr 15, 2026
- Move statusBarEl click listener to onload() to prevent accumulation
- Use sourcePath for archive instead of recomputing path (subfolder fix)
- Cache vault index and invalidate on file changes (was O(n) per keystroke)
- Extract filterSchemaList() shared helper for search logic
- Normalize paths before traversal check
- Fix empty schemaDir edge case in isSchemaFile
- Vault index: full path first, basename first-wins for duplicates
- Add site/ to gitignore, fix package name in lockfile, emoji validator
- Move statusBarEl click listener to onload() to prevent accumulation - Use sourcePath for archive instead of recomputing path (subfolder fix) - Cache vault index and invalidate on file changes (was O(n) per keystroke) - Extract filterSchemaList() shared helper for search logic - Normalize paths before traversal check - Fix empty schemaDir edge case in isSchemaFile - Vault index: full path first, basename first-wins for duplicates - Add site/ to gitignore, fix package name in lockfile, emoji validator Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
Junior Code ReviewSolid bugfix PR addressing listener leaks, caching, and edge cases. The changes are well-structured and the fixes are appropriate. One minor note on path normalization but nothing blocking. Findings
🟢 Low
Reviewed by Junior AI | claudecode | 154,682 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.