This repository was archived by the owner on Mar 11, 2024. It is now read-only.
Use supported elasticsearch client#6
Open
michaelkirk wants to merge 3 commits intomissinglink:masterfrom
Open
Conversation
This is compatible with elasticsearch 7 and 8 For details see the long deprecation plan for the _type field: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the deprecated
elasticsearchpackage with it's successor@elastic/elasticsearch.This is required by pelias/schema#488
I did run the tests locally, but most of my confidence comes from it being used in my elastic8 fork of pelias/schema.
See the mostly* successful CI run https://github.com/michaelkirk-pelias/schema/actions/runs/5274562778/jobs/9539146582
*CI is only failing because I don't have docker privs set up - the unit and integration tests are passing on es7 and es8.